Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slideshow: add filter to customize speed of the Slideshow #3297

Merged
merged 4 commits into from
Feb 8, 2017

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jan 19, 2016

This filter change should allow site owners to change the speed of all slideshows on their site, like so:

function jeherve_fast_slideshow( $args ) {
    $new_speed = array(
        'speed' => '10'
    );
    return array_replace( $args, $new_speed );
}
add_filter( 'jetpack_js_slideshow_settings', 'jeherve_fast_slideshow' );

Suggested in https://wordpress.org/support/topic/gallery-slideshow-settings-editable-somehow

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Shortcodes / Embeds labels Jan 19, 2016
@jeherve jeherve added this to the 4.0 milestone Jan 19, 2016
@jeherve jeherve modified the milestones: 4.2, 4.1 Jun 17, 2016
@jeherve jeherve modified the milestones: 4.3, 4.2 Jul 6, 2016
@richardmuscat richardmuscat modified the milestones: 4.3, 4.4 Jul 7, 2016
@samhotchkiss samhotchkiss modified the milestones: Not Currently Planned, 4.4 Nov 9, 2016
@samhotchkiss
Copy link
Contributor

Moved out of the pipeline until it's completed

@eliorivero
Copy link
Contributor

@jeherve is there anything else you need to add? This is working fine on my tests and it just needs a rebase before merging.

@jeherve jeherve force-pushed the add/slideshow-speed branch from f1e7397 to d1806ed Compare February 8, 2017 13:12
@jeherve
Copy link
Member Author

jeherve commented Feb 8, 2017

It seems to work well in my tests as well. I rebased. This should be read for merge.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] In Progress labels Feb 8, 2017
@jeherve jeherve removed this from the Not Currently Planned milestone Feb 8, 2017
@eliorivero eliorivero merged commit 9f8402b into master Feb 8, 2017
@eliorivero eliorivero deleted the add/slideshow-speed branch February 8, 2017 18:29
@eliorivero eliorivero removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 8, 2017
jeherve added a commit that referenced this pull request Feb 8, 2017
jeherve added a commit that referenced this pull request Feb 21, 2017
dereksmart pushed a commit that referenced this pull request Feb 28, 2017
* Changelog: update stable tag and move changelog to changelog.txt

Also remove old releases from readme.txt to keep the changelog tab short.

* Changelog: add #5883

Also update the filter's docblock to match new version.

* Changelog: add #5938

* Changelog: add #6298

* Changelog: add #3405

* Changelog: add #5941

* Changelog: add #6239

* Changelog: add #6281

* Changelog: add #6303

* Changelog: add #6018

* Changelog: add #6300

* Changelog: add #6296

* Changelog: add #6130

* Changelog: add #6292

* Readme: remove extra "on".

* Changelog: add #6307

* Changelog: add #3297

* Changelog: add #6275

* Changelog: add #6321

* Changelog: add #6297

* Readme: update the support forum link anchor.

Anchor changed when WordPress.org forums were updated to bbPress 2

* Readme: update list of a12s, it wasn't up to date anymore!

* Changelog: add #6338

* Changelog: add #6337

* Changelog: add #6335

* Changelog: add #6333

* Testing List: first version of the 4.7 testing list.

* Changelog: add #6332

* Changelog: add #6325

* Changelog: add #6326

* Changelog: add #6339

* Changelog: add #6342

* Changelog: add #6343

* Changelog: add #6346

* Changelog: add #6347

* Changelog: add #6279

* Changelog: add #6306

* Changelog: add #6312

* Changelog: add #6316

* Changelog: add #6171

* Changelog: add #6317

* Changelog: add #6246

* Changelog: add #6263

* Changelog: add #4220

* Changelog: add #5888

* Changelog: add #3406

* Changelog: add #3637

* Changelog: add #6320

* Changelog: add #5992

* Changelog: add #6322

* Changelog: add #6324

* Changelog: add #6352

* Changelog: add #6355

* Changelog: add #6360

* Changelog: add #6362

* Changelog: add #6369, #6382

* Changelog: add #6370

* Changelog: add #6375

* Changelog: add #6383

* Changelog: add #6384

* Changelog: add #6386

* Changelog: add #6395

* Changelog: add #6403

* Changelog: add #6406

* Changelog: add #6418

* Changelog: add #6419

* Changelog: add #6434

* Changelog: add #6446

* Changelog: add #6006

* Changelog: add #6096

* Changelog: add #6399

* Changelog: fix typo.

@see #6331 (comment)

* Changelog: add #6440

* Changelog: add #6443

* Changelog: add #6445

* Changelog: add #6463

* Changelog: add #6468

* Changelog: add #6471

* Changelog: add #6474

* Changelog: add #6480

* Changelog: add #6497

* Changelog: add #6499

* Changelog: add #6514

* Changelog: add #6267

* Changelog: add #5940

* Changelog: add #6492

* Changelog: add #5281

* Changelog: add #6327

* Changelog: add #6451

* Changelog: add #6525

* Changelog: add #6530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Shortcodes / Embeds [Pri] Low Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants