Extra Sidebar Widgets: update Twitter Timeline for sane limit

[lancewillett]

Syncs (part of) r148193-wpcom

Changes proposed in this Pull Request:

Update the labeling of this widget to be obvious about 1 - 20 range of tweets for the widget display.

Testing instructions:

• Enable the Twitter Timeline widget.
• Check the form to make sure the # of Tweets Shown (1 to 20): text appears.
• Try adding more than 20; the form should reset back to 20 upon save.

Note: There is no lower limit. If empty Twitter decides the limit.

[niallkennedy]

This diff matches the behavior of Twitter's oEmbed servers when receiving a limit query parameter out of supported range: the top accepted value in the range is returned in the data-tweet-limit attribute.

Example:
https://publish.twitter.com/oembed?/oembed?url=https%3A%2F%2Ftwitter.com%2FWordPress&limit=42

The range was already present in the input[type=number] min and max values. This diff adds server-side enforcement of that communicated range.

Code style of the diff varies slightly from the width range style:

$instance['width'] = min( max( $width, 220 ), 1200 );

or height:

$instance['height'] = max( $height, 200 );

vs. int conversion and a value exceeding the top of the range but no comparison of the bottom. Accepting 0, -1, etc?

Possible enhancement: a timeline with a specified limit is expanded to the height of those Tweets; the specified height value no longer applies. In my code I reject the height value when a valid limit is set: a widget attempting to save both limit 5 and height 400 would be saved with just limit 5.

[lancewillett]

Good ideas for improvement, @niallkennedy — thanks. I'll refresh this pull with a minimum value check and int conversion of width/height values.

Possible enhancement: a timeline with a specified limit is expanded to the height of those Tweets; the specified height value no longer applies. In my code I reject the height value when a valid limit is set: a widget attempting to save both limit 5 and height 400 would be saved with just limit 5.

That's a great idea, too. Cheers.

[lancewillett]

Made the suggested changes - ready for more review and testing.

[niallkennedy]

looks good, thanks

[lancewillett]

@eliorivero Can you take a look, test, and merge?

[eliorivero]

LGTM!
Tested in Customizer and WP Admin, all good.
Merging as requested.