Fix Publicize to Facebook for en_AU and en_CA locales #3347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "Fix for missing Facebook button certain languages" This reverts commit d1c7759.
nylen
added
[Type] Bug
nylen
added
[Status] Needs Review
|
You win this round, bot |
jeherve
added
[Feature] Publicize
zinigor
added
[Status] Ready to Merge
|
Looks good, tested, works as expected! |
jeherve
added a commit
that referenced
this pull request
Feb 10, 2016
Fix Publicize to Facebook for en_AU and en_CA locales
jeherve
removed
the
[Status] Ready to Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where Publicize to Facebook silently fails for blogs in the
en_AUanden_CAlocales. The failures are due to #2117 and the fix is to revert it. As a bonus this also bringslocales.phpcloser to being in sync with WPCOM.If a locale has a
facebook_localevalue, we send that value to Facebook via theog:localetag, which, for these two locales, causes Publicize to fail, presumably because neither of these two codes are in Facebook's list of supported locales. Ref: 471-gh-ioWith af8e40f the desired effect of #2117 is still preserved after this change (the Facebook sharing buttons will still show up for these locales).