Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid Facebook language codes #3026

Closed
pento opened this issue Nov 17, 2015 · 5 comments
Closed

Invalid Facebook language codes #3026

pento opened this issue Nov 17, 2015 · 5 comments
Labels
[Focus] i18n Internationalization / i18n, adaptation to different languages General [Type] Bug When a feature is broken and / or not performing as intended

Comments

@pento
Copy link
Contributor

pento commented Nov 17, 2015

As much as it pains me to acknowledge this, Facebook doesn't support en_AU (or en_CA, for that matter) as language codes in OG tags.

For example, if you Fetch Fresh Scrape Information in this Facebook OG Debug Tool link, you'll get the error:

Object at URL 'http://pento.net/2015/11/17/replacing-rdio/' of type 'article' is invalid because the given value 'en_au' for property 'og:locale:locale' could not be parsed as type 'enum'.

The full list of locales that Facebook supports is here: https://www.facebook.com/translations/FacebookLocales.xml
@kraftbj
Copy link
Contributor

kraftbj commented Nov 17, 2015

Being done here https://github.com/Automattic/jetpack/blob/master/functions.opengraph.php#L193
https://github.com/Automattic/jetpack/blob/master/locales.php#L557
Vs https://glotpress.trac.wordpress.org/browser/trunk/locales/locales.php#L572

@kraftbj kraftbj added [Type] Bug When a feature is broken and / or not performing as intended General labels Nov 17, 2015
@kraftbj kraftbj added this to the 3.8.2 milestone Nov 17, 2015
@jeherve
Copy link
Member

jeherve commented Nov 17, 2015

Related: #2791, #2821, #2707

@jeherve jeherve added the [Focus] i18n Internationalization / i18n, adaptation to different languages label Nov 17, 2015
@jeherve
Copy link
Member

jeherve commented Dec 16, 2015

Fixed for the Like Box in #3160

@jeherve jeherve modified the milestones: 3.9, 3.8.2 Dec 16, 2015
@jeherve jeherve modified the milestones: 4.0, 3.9 Jan 15, 2016
@richardmtl
Copy link
Contributor

Related: #3347

@jeherve jeherve modified the milestones: 4.1, 4.3 Jun 17, 2016
@richardmuscat richardmuscat modified the milestones: 4.3, 4.4 Jul 7, 2016
@jeherve jeherve mentioned this issue Nov 2, 2016
Closed
@samhotchkiss samhotchkiss modified the milestones: 4.4, Not Currently Planned Nov 9, 2016
@jeherve
Copy link
Member

jeherve commented Apr 10, 2017

Fixed in #3160.

Better fallbacks should still be implemented, as explained in #5468

@jeherve jeherve closed this as completed Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Focus] i18n Internationalization / i18n, adaptation to different languages General [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kraftbj @pento @jeherve @samhotchkiss @richardmuscat @richardmtl