Declare render delegate "stop render" instead of pause #2179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
We were previously returning true in render delegate's
IsPauseSupportedand interrupting the render when pause was called. Then, for "resume render" we were simply restarting it from scratch, since arnold currently doesn't support pause & resume rendering. This PR removes the "pause" functions from our render delegate (which defaults to pause not being supported), and instead returns true inIsStopSupported. In Solaris, this will replace the previous "Pause Render" menu with "Stop Render".It then removes several issues that happened because of the render pause (e.g. render restarting in Solaris when the AOVs are changed in Houdini 20.5)
Issues fixed in this pull request
Fixes #2177