Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make nbdev_create_config write the black_formatting setting #1235

Closed

Conversation

dmose
Copy link

@dmose dmose commented Nov 29, 2022

fixes #1231

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jph00 jph00 added the bug Something isn't working label Feb 3, 2023
@jph00
Copy link
Contributor

jph00 commented Feb 3, 2023

Apologies I'm not sure how to fix this conflict, so I'll make the change at my end and credit you in the release notes - hope that's OK.

@jph00 jph00 closed this Feb 3, 2023
@dmose
Copy link
Author

dmose commented Feb 3, 2023

No worries; thanks for landing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nbdev_create_config doesnt add black_formatting option
2 participants