Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbdev_create_config doesnt add black_formatting option #1231

Closed
saschahofmann opened this issue Nov 22, 2022 · 3 comments
Closed

nbdev_create_config doesnt add black_formatting option #1231

saschahofmann opened this issue Nov 22, 2022 · 3 comments

Comments

@saschahofmann
Copy link

I am creating the config file via nbdev_create_config --black_formatting True but the option isn't added to the created settings.ini. I am a receiving a warning because I am using a private repo without having set the GITHUB_TOKEN but the same happens when I run the command in a completely empty repo.

On another note, it's not clear to me when the notebooks should be formatted? I hoped it would happen when saving the notebook but I couldnt trigger the black formatting after having added the setting manually?

@seeM
Copy link
Contributor

seeM commented Nov 25, 2022

The black_formatting option only applies to the exported Python files. The notebooks themselves don't get formatted.

@saschahofmann
Copy link
Author

Ah gotcha! About the first part though: Am I wrong in assuming that this command nbdev_create_config --black_formatting True should generate a config file with the option set to true?

@hugetim
Copy link
Contributor

hugetim commented Feb 5, 2023

Addressed by 066a88e

@seeM seeM closed this as completed Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants