Smart contract call bugfix #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vukiz
requested changes
Mar 28, 2023
Assets/MirageSDK/Examples/Scripts/WearableNFTExample/WearableNFTExample.cs
Outdated
Show resolved
Hide resolved
Assets/MirageSDK/Plugins/WalletConnectSharp.Core/WalletConnectProtocol.cs
Outdated
Show resolved
Hide resolved
Assets/MirageSDK/Plugins/WalletConnectSharp.Core/WalletConnectSession.cs
Outdated
Show resolved
Hide resolved
Assets/MirageSDK/Plugins/WalletConnectSharp.Unity/Network/Client/Implementation/WebSocket.cs
Outdated
Show resolved
Hide resolved
Assets/MirageSDK/Plugins/WalletConnectSharp.Unity/Network/Client/Implementation/WebSocket.cs
Outdated
Show resolved
Hide resolved
|
Please remove unnecessary changes and unused methods |
Vukiz
approved these changes
Mar 28, 2023
Antivortex
added a commit
that referenced
this pull request
Mar 30, 2023
* debug contract data loading * additional log * Smart contract call bugfix (#115) * smart contract fixing wip * teardown location bugfix * additional debug logs * remove debug lines * format and compile errors * post review fixes
Antivortex
added a commit
that referenced
this pull request
Mar 30, 2023
* WC2 + refactor changes to dev (#110) * WalletConnect 2 Unity implementation intermediate phase (#100) * wc2 dlls finished * wallet connect interface minor change * nuget generated dlls * wc2 wip * wallet connect 2 wip * wallet connect 2 wip * wallet connect 2 wip: intermediate version finished * Upgrade version (#99) * package version upgrade (#98) * remove unused modificator * utils usage adjutment * example removed * namespace auto adjustment * webgl compilation test fix * minor interface renaming * reference minor fix * don't use guids references * post review updates --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> * Wallet connect 2 phase 2 (#102) * wc2 dlls finished * wallet connect interface minor change * nuget generated dlls * wc2 wip * wallet connect 2 wip * wallet connect 2 wip * wallet connect 2 wip: intermediate version finished * Upgrade version (#99) * package version upgrade (#98) * remove unused modificator * utils usage adjutment * example removed * namespace auto adjustment * webgl compilation test fix * minor interface renaming * reference minor fix * don't use guids references * post review updates * wallet connect rpc implementation * minor fix * wc2 settings asset created * style change: break lines where needed --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> * Add method to set token (#101) * fixed minor bugs * Wallet connect 2 phase 3 (#103) * wc2 dlls finished * wallet connect interface minor change * nuget generated dlls * wc2 wip * wallet connect 2 wip * wallet connect 2 wip * wallet connect 2 wip: intermediate version finished * Upgrade version (#99) * package version upgrade (#98) * remove unused modificator * utils usage adjutment * example removed * namespace auto adjustment * webgl compilation test fix * minor interface renaming * reference minor fix * don't use guids references * post review updates * wallet connect rpc implementation * minor fix * wc2 settings asset created * wc 2 phase 3 wip * wallet connect 2 silent signing compatability * wallet connect 2 wip * network dll update * meta guids updated * dlls updated (namespaces changed) * account and network methods implemented in WC2 * code style update * review update * make nested classes private * wc2 settings fix * add chain namespace argument to the methods determining default chain and account * summaries for methods containing chain namespaces --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> * Wallet connect 2 docs (#106) * migration to 0.6.0 breaking changes migration guide * migration from wc1 to wc2 doc * docs update * Update migration-from-wc1-to-wc2.md * Update migration-from-wc1-to-wc2.md * hex extension usage fix * minor comment fix * Refactor AnkrSDK examples: UI refactoring finished (#107) * refactor wc scenes wip * test scene adjusted to scale for both portrait and landscape mode * demo root scene buttons adjusted * ugui tools removed * ConnectionController adjusted * can send request inversed logic bug bug * logical inversion * wc2 replaced to 2c where needed * demo screen update * method name bugfix for updateChain * logging improvement for test cases * rinkeby changed to goerli * nft contract examples refactoring wip * comment contracts * Wallet connect 2 docs (#106) * migration to 0.6.0 breaking changes migration guide * migration from wc1 to wc2 doc * docs update * Update migration-from-wc1-to-wc2.md * Update migration-from-wc1-to-wc2.md * hex extension usage fix * minor comment fix * Remove wc2 in a single commit (#108) * hex extension usage fix * minor comment fix * wallet connect 2 single commit removal * all related active flags renamed to isActive * Fix nft example issues (#109) * refactor wc scenes wip * test scene adjusted to scale for both portrait and landscape mode * demo root scene buttons adjusted * ugui tools removed * ConnectionController adjusted * can send request inversed logic bug bug * logical inversion * wc2 replaced to 2c where needed * demo screen update * method name bugfix for updateChain * logging improvement for test cases * rinkeby changed to goerli * nft contract examples refactoring wip * comment contracts * Wallet connect 2 docs (#106) * migration to 0.6.0 breaking changes migration guide * migration from wc1 to wc2 doc * docs update * Update migration-from-wc1-to-wc2.md * Update migration-from-wc1-to-wc2.md * hex extension usage fix * minor comment fix * nft examples fix wip * fix nft examples wip * abi related bugfix * examples issues fixing in progress * event handling * nft demo scenes fixing wip * final tweaks to the nft example issues * format file * minor naming fixes * files reformatting * Update README.md (#104) * GitHub action to update version in a file (#105) * github action to modify package json * minor fix * handle missing tag case * typo fix * yaml syntax fix * autocommit changes * git commit commands modification * git commit command modification * git commit command modification * update commit command * git commit and push command modified * silence all safe.directory warnings * git commands update * upgrade git push action version * update pushed tag * tags usage removed * set tags to false * run workflow on git push * add git status command * git diff index command added * if else check improved * create file * push to branch * another attempt to push to branch * more logs * branch name reading improvement * get branch name different approach * commit and push tag update to a new branch * push in a different way * push tag separately * move tag to a new commit * tag update workflow improvements * move a git tag to a current commit * git action workflow polished * additional log * additional checkout to be not in a detatched head state * add fetch command * add stashing commands for checkouts * git add command to stage changes for commit * Automated tag update for v0.5.5 * permission related typo fix * rever version * specify ref * remove unused line * Automated tag update for v0.5.5 * do things in different order * revert tag * commands order issue fix * Automated tag update for * bash variable update * revert package json * Automated tag update for v0.5.5 * push tag alternitively * Revert "Automated tag update for v0.5.5" This reverts commit 12f5643. * Automated tag update for v0.5.5 * typo fix * Revert "Automated tag update for v0.5.5" This reverts commit 3dd9531. * Automated tag update for v0.5.5 * different way to move tag * Revert "Automated tag update for v0.5.5" This reverts commit 741f8a4. * Automated tag update for v0.5.5 * alternative way to move tag * Revert "Automated tag update for v0.5.5" This reverts commit 4596733. * Automated tag update for v0.5.5 * tag a particular commit * Revert "Automated tag update for v0.5.5" This reverts commit 55bcd4c. * Automated tag update for v0.5.5 * more detailed logging * Revert "Automated tag update for v0.5.5" This reverts commit a4e5b53. * Automated tag update for v0.5.5 * Revert "Automated tag update for v0.5.5" This reverts commit 0fb9382. * better tag name filter * improved commit name * minor renaming * move py script to different folder * Automated package.json version update for tag v0.5.5 * Revert "Automated package.json version update for tag v0.5.5" This reverts commit aba73ac. --------- Co-authored-by: GitHub Actions <actions@github.com> * remove update nft use case from the grid * spaces removed --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> Co-authored-by: alekseeveg <alekseev@ankr.com> Co-authored-by: kwame <kwame@nebulachain.io> Co-authored-by: GitHub Actions <actions@github.com> * AnkrSDK to MirageSDK renaming (#111) * WalletConnect 2 Unity implementation intermediate phase (#100) * wc2 dlls finished * wallet connect interface minor change * nuget generated dlls * wc2 wip * wallet connect 2 wip * wallet connect 2 wip * wallet connect 2 wip: intermediate version finished * Upgrade version (#99) * package version upgrade (#98) * remove unused modificator * utils usage adjutment * example removed * namespace auto adjustment * webgl compilation test fix * minor interface renaming * reference minor fix * don't use guids references * post review updates --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> * Wallet connect 2 phase 2 (#102) * wc2 dlls finished * wallet connect interface minor change * nuget generated dlls * wc2 wip * wallet connect 2 wip * wallet connect 2 wip * wallet connect 2 wip: intermediate version finished * Upgrade version (#99) * package version upgrade (#98) * remove unused modificator * utils usage adjutment * example removed * namespace auto adjustment * webgl compilation test fix * minor interface renaming * reference minor fix * don't use guids references * post review updates * wallet connect rpc implementation * minor fix * wc2 settings asset created * style change: break lines where needed --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> * Add method to set token (#101) * fixed minor bugs * Wallet connect 2 phase 3 (#103) * wc2 dlls finished * wallet connect interface minor change * nuget generated dlls * wc2 wip * wallet connect 2 wip * wallet connect 2 wip * wallet connect 2 wip: intermediate version finished * Upgrade version (#99) * package version upgrade (#98) * remove unused modificator * utils usage adjutment * example removed * namespace auto adjustment * webgl compilation test fix * minor interface renaming * reference minor fix * don't use guids references * post review updates * wallet connect rpc implementation * minor fix * wc2 settings asset created * wc 2 phase 3 wip * wallet connect 2 silent signing compatability * wallet connect 2 wip * network dll update * meta guids updated * dlls updated (namespaces changed) * account and network methods implemented in WC2 * code style update * review update * make nested classes private * wc2 settings fix * add chain namespace argument to the methods determining default chain and account * summaries for methods containing chain namespaces --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> * Wallet connect 2 docs (#106) * migration to 0.6.0 breaking changes migration guide * migration from wc1 to wc2 doc * docs update * Update migration-from-wc1-to-wc2.md * Update migration-from-wc1-to-wc2.md * hex extension usage fix * minor comment fix * Refactor AnkrSDK examples: UI refactoring finished (#107) * refactor wc scenes wip * test scene adjusted to scale for both portrait and landscape mode * demo root scene buttons adjusted * ugui tools removed * ConnectionController adjusted * can send request inversed logic bug bug * logical inversion * wc2 replaced to 2c where needed * demo screen update * method name bugfix for updateChain * logging improvement for test cases * rinkeby changed to goerli * nft contract examples refactoring wip * comment contracts * Wallet connect 2 docs (#106) * migration to 0.6.0 breaking changes migration guide * migration from wc1 to wc2 doc * docs update * Update migration-from-wc1-to-wc2.md * Update migration-from-wc1-to-wc2.md * hex extension usage fix * minor comment fix * Remove wc2 in a single commit (#108) * hex extension usage fix * minor comment fix * wallet connect 2 single commit removal * all related active flags renamed to isActive * Fix nft example issues (#109) * refactor wc scenes wip * test scene adjusted to scale for both portrait and landscape mode * demo root scene buttons adjusted * ugui tools removed * ConnectionController adjusted * can send request inversed logic bug bug * logical inversion * wc2 replaced to 2c where needed * demo screen update * method name bugfix for updateChain * logging improvement for test cases * rinkeby changed to goerli * nft contract examples refactoring wip * comment contracts * Wallet connect 2 docs (#106) * migration to 0.6.0 breaking changes migration guide * migration from wc1 to wc2 doc * docs update * Update migration-from-wc1-to-wc2.md * Update migration-from-wc1-to-wc2.md * hex extension usage fix * minor comment fix * nft examples fix wip * fix nft examples wip * abi related bugfix * examples issues fixing in progress * event handling * nft demo scenes fixing wip * final tweaks to the nft example issues * format file * minor naming fixes * files reformatting * Update README.md (#104) * GitHub action to update version in a file (#105) * github action to modify package json * minor fix * handle missing tag case * typo fix * yaml syntax fix * autocommit changes * git commit commands modification * git commit command modification * git commit command modification * update commit command * git commit and push command modified * silence all safe.directory warnings * git commands update * upgrade git push action version * update pushed tag * tags usage removed * set tags to false * run workflow on git push * add git status command * git diff index command added * if else check improved * create file * push to branch * another attempt to push to branch * more logs * branch name reading improvement * get branch name different approach * commit and push tag update to a new branch * push in a different way * push tag separately * move tag to a new commit * tag update workflow improvements * move a git tag to a current commit * git action workflow polished * additional log * additional checkout to be not in a detatched head state * add fetch command * add stashing commands for checkouts * git add command to stage changes for commit * Automated tag update for v0.5.5 * permission related typo fix * rever version * specify ref * remove unused line * Automated tag update for v0.5.5 * do things in different order * revert tag * commands order issue fix * Automated tag update for * bash variable update * revert package json * Automated tag update for v0.5.5 * push tag alternitively * Revert "Automated tag update for v0.5.5" This reverts commit 12f5643. * Automated tag update for v0.5.5 * typo fix * Revert "Automated tag update for v0.5.5" This reverts commit 3dd9531. * Automated tag update for v0.5.5 * different way to move tag * Revert "Automated tag update for v0.5.5" This reverts commit 741f8a4. * Automated tag update for v0.5.5 * alternative way to move tag * Revert "Automated tag update for v0.5.5" This reverts commit 4596733. * Automated tag update for v0.5.5 * tag a particular commit * Revert "Automated tag update for v0.5.5" This reverts commit 55bcd4c. * Automated tag update for v0.5.5 * more detailed logging * Revert "Automated tag update for v0.5.5" This reverts commit a4e5b53. * Automated tag update for v0.5.5 * Revert "Automated tag update for v0.5.5" This reverts commit 0fb9382. * better tag name filter * improved commit name * minor renaming * move py script to different folder * Automated package.json version update for tag v0.5.5 * Revert "Automated package.json version update for tag v0.5.5" This reverts commit aba73ac. --------- Co-authored-by: GitHub Actions <actions@github.com> * remove update nft use case from the grid * ankr to mirage renaming # Conflicts: # Assets/MirageSDK/Examples/UseCases/LoadNFTs/LoadNFTExample.cs # Assets/MirageSDK/Runtime/Core/Implementation/ContractEventSubscriber.cs # Assets/MirageSDK/Runtime/Data/ABIStringLoader.cs # Assets/MirageSDK/package.json * rename variables # Conflicts: # Assets/MirageSDK/Examples/Scripts/WearableNFTExample/WearableNFTExample.cs * ads renaming * package version upgrade * spaces removed * spaces removed * ankr to mirage renaming # Conflicts: # Assets/MirageSDK/Examples/UseCases/LoadNFTs/LoadNFTExample.cs # Assets/MirageSDK/Runtime/Core/Implementation/ContractEventSubscriber.cs # Assets/MirageSDK/Runtime/Data/ABIStringLoader.cs # Assets/MirageSDK/package.json --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> Co-authored-by: alekseeveg <alekseev@ankr.com> Co-authored-by: kwame <kwame@nebulachain.io> Co-authored-by: GitHub Actions <actions@github.com> * minor button positions adjustment * [MC-116] Actualise webgl (#113) * Change chain switch method * Change method name, add jslib for nethereum * Fix bug with nethereum jslib * Remove redundant files, back Unity version * Remove log and add reference * Change chain interface to return empty task --------- Co-authored-by: sidorovk <sidorovk@phxlts.com> * debug contract data loading (#114) * debug contract data loading * additional log * Smart contract call bugfix (#115) * smart contract fixing wip * teardown location bugfix * additional debug logs * remove debug lines * format and compile errors * post review fixes * mirage api removed to be added to widget repo (#116) --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> Co-authored-by: alekseeveg <alekseev@ankr.com> Co-authored-by: kwame <kwame@nebulachain.io> Co-authored-by: GitHub Actions <actions@github.com> Co-authored-by: sidorovk <sidorovk@phxlts.com>
Antivortex
added a commit
that referenced
this pull request
Apr 10, 2023
* WC2 + refactor changes to dev (#110) * WalletConnect 2 Unity implementation intermediate phase (#100) * wc2 dlls finished * wallet connect interface minor change * nuget generated dlls * wc2 wip * wallet connect 2 wip * wallet connect 2 wip * wallet connect 2 wip: intermediate version finished * Upgrade version (#99) * package version upgrade (#98) * remove unused modificator * utils usage adjutment * example removed * namespace auto adjustment * webgl compilation test fix * minor interface renaming * reference minor fix * don't use guids references * post review updates --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> * Wallet connect 2 phase 2 (#102) * wc2 dlls finished * wallet connect interface minor change * nuget generated dlls * wc2 wip * wallet connect 2 wip * wallet connect 2 wip * wallet connect 2 wip: intermediate version finished * Upgrade version (#99) * package version upgrade (#98) * remove unused modificator * utils usage adjutment * example removed * namespace auto adjustment * webgl compilation test fix * minor interface renaming * reference minor fix * don't use guids references * post review updates * wallet connect rpc implementation * minor fix * wc2 settings asset created * style change: break lines where needed --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> * Add method to set token (#101) * fixed minor bugs * Wallet connect 2 phase 3 (#103) * wc2 dlls finished * wallet connect interface minor change * nuget generated dlls * wc2 wip * wallet connect 2 wip * wallet connect 2 wip * wallet connect 2 wip: intermediate version finished * Upgrade version (#99) * package version upgrade (#98) * remove unused modificator * utils usage adjutment * example removed * namespace auto adjustment * webgl compilation test fix * minor interface renaming * reference minor fix * don't use guids references * post review updates * wallet connect rpc implementation * minor fix * wc2 settings asset created * wc 2 phase 3 wip * wallet connect 2 silent signing compatability * wallet connect 2 wip * network dll update * meta guids updated * dlls updated (namespaces changed) * account and network methods implemented in WC2 * code style update * review update * make nested classes private * wc2 settings fix * add chain namespace argument to the methods determining default chain and account * summaries for methods containing chain namespaces --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> * Wallet connect 2 docs (#106) * migration to 0.6.0 breaking changes migration guide * migration from wc1 to wc2 doc * docs update * Update migration-from-wc1-to-wc2.md * Update migration-from-wc1-to-wc2.md * hex extension usage fix * minor comment fix * Refactor AnkrSDK examples: UI refactoring finished (#107) * refactor wc scenes wip * test scene adjusted to scale for both portrait and landscape mode * demo root scene buttons adjusted * ugui tools removed * ConnectionController adjusted * can send request inversed logic bug bug * logical inversion * wc2 replaced to 2c where needed * demo screen update * method name bugfix for updateChain * logging improvement for test cases * rinkeby changed to goerli * nft contract examples refactoring wip * comment contracts * Wallet connect 2 docs (#106) * migration to 0.6.0 breaking changes migration guide * migration from wc1 to wc2 doc * docs update * Update migration-from-wc1-to-wc2.md * Update migration-from-wc1-to-wc2.md * hex extension usage fix * minor comment fix * Remove wc2 in a single commit (#108) * hex extension usage fix * minor comment fix * wallet connect 2 single commit removal * all related active flags renamed to isActive * Fix nft example issues (#109) * refactor wc scenes wip * test scene adjusted to scale for both portrait and landscape mode * demo root scene buttons adjusted * ugui tools removed * ConnectionController adjusted * can send request inversed logic bug bug * logical inversion * wc2 replaced to 2c where needed * demo screen update * method name bugfix for updateChain * logging improvement for test cases * rinkeby changed to goerli * nft contract examples refactoring wip * comment contracts * Wallet connect 2 docs (#106) * migration to 0.6.0 breaking changes migration guide * migration from wc1 to wc2 doc * docs update * Update migration-from-wc1-to-wc2.md * Update migration-from-wc1-to-wc2.md * hex extension usage fix * minor comment fix * nft examples fix wip * fix nft examples wip * abi related bugfix * examples issues fixing in progress * event handling * nft demo scenes fixing wip * final tweaks to the nft example issues * format file * minor naming fixes * files reformatting * Update README.md (#104) * GitHub action to update version in a file (#105) * github action to modify package json * minor fix * handle missing tag case * typo fix * yaml syntax fix * autocommit changes * git commit commands modification * git commit command modification * git commit command modification * update commit command * git commit and push command modified * silence all safe.directory warnings * git commands update * upgrade git push action version * update pushed tag * tags usage removed * set tags to false * run workflow on git push * add git status command * git diff index command added * if else check improved * create file * push to branch * another attempt to push to branch * more logs * branch name reading improvement * get branch name different approach * commit and push tag update to a new branch * push in a different way * push tag separately * move tag to a new commit * tag update workflow improvements * move a git tag to a current commit * git action workflow polished * additional log * additional checkout to be not in a detatched head state * add fetch command * add stashing commands for checkouts * git add command to stage changes for commit * Automated tag update for v0.5.5 * permission related typo fix * rever version * specify ref * remove unused line * Automated tag update for v0.5.5 * do things in different order * revert tag * commands order issue fix * Automated tag update for * bash variable update * revert package json * Automated tag update for v0.5.5 * push tag alternitively * Revert "Automated tag update for v0.5.5" This reverts commit 12f5643. * Automated tag update for v0.5.5 * typo fix * Revert "Automated tag update for v0.5.5" This reverts commit 3dd9531. * Automated tag update for v0.5.5 * different way to move tag * Revert "Automated tag update for v0.5.5" This reverts commit 741f8a4. * Automated tag update for v0.5.5 * alternative way to move tag * Revert "Automated tag update for v0.5.5" This reverts commit 4596733. * Automated tag update for v0.5.5 * tag a particular commit * Revert "Automated tag update for v0.5.5" This reverts commit 55bcd4c. * Automated tag update for v0.5.5 * more detailed logging * Revert "Automated tag update for v0.5.5" This reverts commit a4e5b53. * Automated tag update for v0.5.5 * Revert "Automated tag update for v0.5.5" This reverts commit 0fb9382. * better tag name filter * improved commit name * minor renaming * move py script to different folder * Automated package.json version update for tag v0.5.5 * Revert "Automated package.json version update for tag v0.5.5" This reverts commit aba73ac. --------- Co-authored-by: GitHub Actions <actions@github.com> * remove update nft use case from the grid * spaces removed --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> Co-authored-by: alekseeveg <alekseev@ankr.com> Co-authored-by: kwame <kwame@nebulachain.io> Co-authored-by: GitHub Actions <actions@github.com> * AnkrSDK to MirageSDK renaming (#111) * WalletConnect 2 Unity implementation intermediate phase (#100) * wc2 dlls finished * wallet connect interface minor change * nuget generated dlls * wc2 wip * wallet connect 2 wip * wallet connect 2 wip * wallet connect 2 wip: intermediate version finished * Upgrade version (#99) * package version upgrade (#98) * remove unused modificator * utils usage adjutment * example removed * namespace auto adjustment * webgl compilation test fix * minor interface renaming * reference minor fix * don't use guids references * post review updates --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> * Wallet connect 2 phase 2 (#102) * wc2 dlls finished * wallet connect interface minor change * nuget generated dlls * wc2 wip * wallet connect 2 wip * wallet connect 2 wip * wallet connect 2 wip: intermediate version finished * Upgrade version (#99) * package version upgrade (#98) * remove unused modificator * utils usage adjutment * example removed * namespace auto adjustment * webgl compilation test fix * minor interface renaming * reference minor fix * don't use guids references * post review updates * wallet connect rpc implementation * minor fix * wc2 settings asset created * style change: break lines where needed --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> * Add method to set token (#101) * fixed minor bugs * Wallet connect 2 phase 3 (#103) * wc2 dlls finished * wallet connect interface minor change * nuget generated dlls * wc2 wip * wallet connect 2 wip * wallet connect 2 wip * wallet connect 2 wip: intermediate version finished * Upgrade version (#99) * package version upgrade (#98) * remove unused modificator * utils usage adjutment * example removed * namespace auto adjustment * webgl compilation test fix * minor interface renaming * reference minor fix * don't use guids references * post review updates * wallet connect rpc implementation * minor fix * wc2 settings asset created * wc 2 phase 3 wip * wallet connect 2 silent signing compatability * wallet connect 2 wip * network dll update * meta guids updated * dlls updated (namespaces changed) * account and network methods implemented in WC2 * code style update * review update * make nested classes private * wc2 settings fix * add chain namespace argument to the methods determining default chain and account * summaries for methods containing chain namespaces --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> * Wallet connect 2 docs (#106) * migration to 0.6.0 breaking changes migration guide * migration from wc1 to wc2 doc * docs update * Update migration-from-wc1-to-wc2.md * Update migration-from-wc1-to-wc2.md * hex extension usage fix * minor comment fix * Refactor AnkrSDK examples: UI refactoring finished (#107) * refactor wc scenes wip * test scene adjusted to scale for both portrait and landscape mode * demo root scene buttons adjusted * ugui tools removed * ConnectionController adjusted * can send request inversed logic bug bug * logical inversion * wc2 replaced to 2c where needed * demo screen update * method name bugfix for updateChain * logging improvement for test cases * rinkeby changed to goerli * nft contract examples refactoring wip * comment contracts * Wallet connect 2 docs (#106) * migration to 0.6.0 breaking changes migration guide * migration from wc1 to wc2 doc * docs update * Update migration-from-wc1-to-wc2.md * Update migration-from-wc1-to-wc2.md * hex extension usage fix * minor comment fix * Remove wc2 in a single commit (#108) * hex extension usage fix * minor comment fix * wallet connect 2 single commit removal * all related active flags renamed to isActive * Fix nft example issues (#109) * refactor wc scenes wip * test scene adjusted to scale for both portrait and landscape mode * demo root scene buttons adjusted * ugui tools removed * ConnectionController adjusted * can send request inversed logic bug bug * logical inversion * wc2 replaced to 2c where needed * demo screen update * method name bugfix for updateChain * logging improvement for test cases * rinkeby changed to goerli * nft contract examples refactoring wip * comment contracts * Wallet connect 2 docs (#106) * migration to 0.6.0 breaking changes migration guide * migration from wc1 to wc2 doc * docs update * Update migration-from-wc1-to-wc2.md * Update migration-from-wc1-to-wc2.md * hex extension usage fix * minor comment fix * nft examples fix wip * fix nft examples wip * abi related bugfix * examples issues fixing in progress * event handling * nft demo scenes fixing wip * final tweaks to the nft example issues * format file * minor naming fixes * files reformatting * Update README.md (#104) * GitHub action to update version in a file (#105) * github action to modify package json * minor fix * handle missing tag case * typo fix * yaml syntax fix * autocommit changes * git commit commands modification * git commit command modification * git commit command modification * update commit command * git commit and push command modified * silence all safe.directory warnings * git commands update * upgrade git push action version * update pushed tag * tags usage removed * set tags to false * run workflow on git push * add git status command * git diff index command added * if else check improved * create file * push to branch * another attempt to push to branch * more logs * branch name reading improvement * get branch name different approach * commit and push tag update to a new branch * push in a different way * push tag separately * move tag to a new commit * tag update workflow improvements * move a git tag to a current commit * git action workflow polished * additional log * additional checkout to be not in a detatched head state * add fetch command * add stashing commands for checkouts * git add command to stage changes for commit * Automated tag update for v0.5.5 * permission related typo fix * rever version * specify ref * remove unused line * Automated tag update for v0.5.5 * do things in different order * revert tag * commands order issue fix * Automated tag update for * bash variable update * revert package json * Automated tag update for v0.5.5 * push tag alternitively * Revert "Automated tag update for v0.5.5" This reverts commit 12f5643. * Automated tag update for v0.5.5 * typo fix * Revert "Automated tag update for v0.5.5" This reverts commit 3dd9531. * Automated tag update for v0.5.5 * different way to move tag * Revert "Automated tag update for v0.5.5" This reverts commit 741f8a4. * Automated tag update for v0.5.5 * alternative way to move tag * Revert "Automated tag update for v0.5.5" This reverts commit 4596733. * Automated tag update for v0.5.5 * tag a particular commit * Revert "Automated tag update for v0.5.5" This reverts commit 55bcd4c. * Automated tag update for v0.5.5 * more detailed logging * Revert "Automated tag update for v0.5.5" This reverts commit a4e5b53. * Automated tag update for v0.5.5 * Revert "Automated tag update for v0.5.5" This reverts commit 0fb9382. * better tag name filter * improved commit name * minor renaming * move py script to different folder * Automated package.json version update for tag v0.5.5 * Revert "Automated package.json version update for tag v0.5.5" This reverts commit aba73ac. --------- Co-authored-by: GitHub Actions <actions@github.com> * remove update nft use case from the grid * ankr to mirage renaming # Conflicts: # Assets/MirageSDK/Examples/UseCases/LoadNFTs/LoadNFTExample.cs # Assets/MirageSDK/Runtime/Core/Implementation/ContractEventSubscriber.cs # Assets/MirageSDK/Runtime/Data/ABIStringLoader.cs # Assets/MirageSDK/package.json * rename variables # Conflicts: # Assets/MirageSDK/Examples/Scripts/WearableNFTExample/WearableNFTExample.cs * ads renaming * package version upgrade * spaces removed * spaces removed * ankr to mirage renaming # Conflicts: # Assets/MirageSDK/Examples/UseCases/LoadNFTs/LoadNFTExample.cs # Assets/MirageSDK/Runtime/Core/Implementation/ContractEventSubscriber.cs # Assets/MirageSDK/Runtime/Data/ABIStringLoader.cs # Assets/MirageSDK/package.json --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> Co-authored-by: alekseeveg <alekseev@ankr.com> Co-authored-by: kwame <kwame@nebulachain.io> Co-authored-by: GitHub Actions <actions@github.com> * minor button positions adjustment * [MC-116] Actualise webgl (#113) * Change chain switch method * Change method name, add jslib for nethereum * Fix bug with nethereum jslib * Remove redundant files, back Unity version * Remove log and add reference * Change chain interface to return empty task --------- Co-authored-by: sidorovk <sidorovk@phxlts.com> * debug contract data loading (#114) * debug contract data loading * additional log * Smart contract call bugfix (#115) * smart contract fixing wip * teardown location bugfix * additional debug logs * remove debug lines * format and compile errors * post review fixes * mirage api removed to be added to widget repo (#116) * Update migration-to-0.6.0.md * Update readme for new sdk name (#119) * Update readme for new sdk name * Fix package name and paths --------- Co-authored-by: sidorovk <sidorovk@phxlts.com> * add switch network prefab fix --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> Co-authored-by: alekseeveg <alekseev@ankr.com> Co-authored-by: kwame <kwame@nebulachain.io> Co-authored-by: GitHub Actions <actions@github.com> Co-authored-by: sidorovk <sidorovk@phxlts.com>
Antivortex
added a commit
that referenced
this pull request
Apr 14, 2023
* WC2 + refactor changes to dev (#110) * WalletConnect 2 Unity implementation intermediate phase (#100) * wc2 dlls finished * wallet connect interface minor change * nuget generated dlls * wc2 wip * wallet connect 2 wip * wallet connect 2 wip * wallet connect 2 wip: intermediate version finished * Upgrade version (#99) * package version upgrade (#98) * remove unused modificator * utils usage adjutment * example removed * namespace auto adjustment * webgl compilation test fix * minor interface renaming * reference minor fix * don't use guids references * post review updates --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> * Wallet connect 2 phase 2 (#102) * wc2 dlls finished * wallet connect interface minor change * nuget generated dlls * wc2 wip * wallet connect 2 wip * wallet connect 2 wip * wallet connect 2 wip: intermediate version finished * Upgrade version (#99) * package version upgrade (#98) * remove unused modificator * utils usage adjutment * example removed * namespace auto adjustment * webgl compilation test fix * minor interface renaming * reference minor fix * don't use guids references * post review updates * wallet connect rpc implementation * minor fix * wc2 settings asset created * style change: break lines where needed --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> * Add method to set token (#101) * fixed minor bugs * Wallet connect 2 phase 3 (#103) * wc2 dlls finished * wallet connect interface minor change * nuget generated dlls * wc2 wip * wallet connect 2 wip * wallet connect 2 wip * wallet connect 2 wip: intermediate version finished * Upgrade version (#99) * package version upgrade (#98) * remove unused modificator * utils usage adjutment * example removed * namespace auto adjustment * webgl compilation test fix * minor interface renaming * reference minor fix * don't use guids references * post review updates * wallet connect rpc implementation * minor fix * wc2 settings asset created * wc 2 phase 3 wip * wallet connect 2 silent signing compatability * wallet connect 2 wip * network dll update * meta guids updated * dlls updated (namespaces changed) * account and network methods implemented in WC2 * code style update * review update * make nested classes private * wc2 settings fix * add chain namespace argument to the methods determining default chain and account * summaries for methods containing chain namespaces --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> * Wallet connect 2 docs (#106) * migration to 0.6.0 breaking changes migration guide * migration from wc1 to wc2 doc * docs update * Update migration-from-wc1-to-wc2.md * Update migration-from-wc1-to-wc2.md * hex extension usage fix * minor comment fix * Refactor AnkrSDK examples: UI refactoring finished (#107) * refactor wc scenes wip * test scene adjusted to scale for both portrait and landscape mode * demo root scene buttons adjusted * ugui tools removed * ConnectionController adjusted * can send request inversed logic bug bug * logical inversion * wc2 replaced to 2c where needed * demo screen update * method name bugfix for updateChain * logging improvement for test cases * rinkeby changed to goerli * nft contract examples refactoring wip * comment contracts * Wallet connect 2 docs (#106) * migration to 0.6.0 breaking changes migration guide * migration from wc1 to wc2 doc * docs update * Update migration-from-wc1-to-wc2.md * Update migration-from-wc1-to-wc2.md * hex extension usage fix * minor comment fix * Remove wc2 in a single commit (#108) * hex extension usage fix * minor comment fix * wallet connect 2 single commit removal * all related active flags renamed to isActive * Fix nft example issues (#109) * refactor wc scenes wip * test scene adjusted to scale for both portrait and landscape mode * demo root scene buttons adjusted * ugui tools removed * ConnectionController adjusted * can send request inversed logic bug bug * logical inversion * wc2 replaced to 2c where needed * demo screen update * method name bugfix for updateChain * logging improvement for test cases * rinkeby changed to goerli * nft contract examples refactoring wip * comment contracts * Wallet connect 2 docs (#106) * migration to 0.6.0 breaking changes migration guide * migration from wc1 to wc2 doc * docs update * Update migration-from-wc1-to-wc2.md * Update migration-from-wc1-to-wc2.md * hex extension usage fix * minor comment fix * nft examples fix wip * fix nft examples wip * abi related bugfix * examples issues fixing in progress * event handling * nft demo scenes fixing wip * final tweaks to the nft example issues * format file * minor naming fixes * files reformatting * Update README.md (#104) * GitHub action to update version in a file (#105) * github action to modify package json * minor fix * handle missing tag case * typo fix * yaml syntax fix * autocommit changes * git commit commands modification * git commit command modification * git commit command modification * update commit command * git commit and push command modified * silence all safe.directory warnings * git commands update * upgrade git push action version * update pushed tag * tags usage removed * set tags to false * run workflow on git push * add git status command * git diff index command added * if else check improved * create file * push to branch * another attempt to push to branch * more logs * branch name reading improvement * get branch name different approach * commit and push tag update to a new branch * push in a different way * push tag separately * move tag to a new commit * tag update workflow improvements * move a git tag to a current commit * git action workflow polished * additional log * additional checkout to be not in a detatched head state * add fetch command * add stashing commands for checkouts * git add command to stage changes for commit * Automated tag update for v0.5.5 * permission related typo fix * rever version * specify ref * remove unused line * Automated tag update for v0.5.5 * do things in different order * revert tag * commands order issue fix * Automated tag update for * bash variable update * revert package json * Automated tag update for v0.5.5 * push tag alternitively * Revert "Automated tag update for v0.5.5" This reverts commit 12f5643. * Automated tag update for v0.5.5 * typo fix * Revert "Automated tag update for v0.5.5" This reverts commit 3dd9531. * Automated tag update for v0.5.5 * different way to move tag * Revert "Automated tag update for v0.5.5" This reverts commit 741f8a4. * Automated tag update for v0.5.5 * alternative way to move tag * Revert "Automated tag update for v0.5.5" This reverts commit 4596733. * Automated tag update for v0.5.5 * tag a particular commit * Revert "Automated tag update for v0.5.5" This reverts commit 55bcd4c. * Automated tag update for v0.5.5 * more detailed logging * Revert "Automated tag update for v0.5.5" This reverts commit a4e5b53. * Automated tag update for v0.5.5 * Revert "Automated tag update for v0.5.5" This reverts commit 0fb9382. * better tag name filter * improved commit name * minor renaming * move py script to different folder * Automated package.json version update for tag v0.5.5 * Revert "Automated package.json version update for tag v0.5.5" This reverts commit aba73ac. --------- Co-authored-by: GitHub Actions <actions@github.com> * remove update nft use case from the grid * spaces removed --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> Co-authored-by: alekseeveg <alekseev@ankr.com> Co-authored-by: kwame <kwame@nebulachain.io> Co-authored-by: GitHub Actions <actions@github.com> * AnkrSDK to MirageSDK renaming (#111) * WalletConnect 2 Unity implementation intermediate phase (#100) * wc2 dlls finished * wallet connect interface minor change * nuget generated dlls * wc2 wip * wallet connect 2 wip * wallet connect 2 wip * wallet connect 2 wip: intermediate version finished * Upgrade version (#99) * package version upgrade (#98) * remove unused modificator * utils usage adjutment * example removed * namespace auto adjustment * webgl compilation test fix * minor interface renaming * reference minor fix * don't use guids references * post review updates --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> * Wallet connect 2 phase 2 (#102) * wc2 dlls finished * wallet connect interface minor change * nuget generated dlls * wc2 wip * wallet connect 2 wip * wallet connect 2 wip * wallet connect 2 wip: intermediate version finished * Upgrade version (#99) * package version upgrade (#98) * remove unused modificator * utils usage adjutment * example removed * namespace auto adjustment * webgl compilation test fix * minor interface renaming * reference minor fix * don't use guids references * post review updates * wallet connect rpc implementation * minor fix * wc2 settings asset created * style change: break lines where needed --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> * Add method to set token (#101) * fixed minor bugs * Wallet connect 2 phase 3 (#103) * wc2 dlls finished * wallet connect interface minor change * nuget generated dlls * wc2 wip * wallet connect 2 wip * wallet connect 2 wip * wallet connect 2 wip: intermediate version finished * Upgrade version (#99) * package version upgrade (#98) * remove unused modificator * utils usage adjutment * example removed * namespace auto adjustment * webgl compilation test fix * minor interface renaming * reference minor fix * don't use guids references * post review updates * wallet connect rpc implementation * minor fix * wc2 settings asset created * wc 2 phase 3 wip * wallet connect 2 silent signing compatability * wallet connect 2 wip * network dll update * meta guids updated * dlls updated (namespaces changed) * account and network methods implemented in WC2 * code style update * review update * make nested classes private * wc2 settings fix * add chain namespace argument to the methods determining default chain and account * summaries for methods containing chain namespaces --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> * Wallet connect 2 docs (#106) * migration to 0.6.0 breaking changes migration guide * migration from wc1 to wc2 doc * docs update * Update migration-from-wc1-to-wc2.md * Update migration-from-wc1-to-wc2.md * hex extension usage fix * minor comment fix * Refactor AnkrSDK examples: UI refactoring finished (#107) * refactor wc scenes wip * test scene adjusted to scale for both portrait and landscape mode * demo root scene buttons adjusted * ugui tools removed * ConnectionController adjusted * can send request inversed logic bug bug * logical inversion * wc2 replaced to 2c where needed * demo screen update * method name bugfix for updateChain * logging improvement for test cases * rinkeby changed to goerli * nft contract examples refactoring wip * comment contracts * Wallet connect 2 docs (#106) * migration to 0.6.0 breaking changes migration guide * migration from wc1 to wc2 doc * docs update * Update migration-from-wc1-to-wc2.md * Update migration-from-wc1-to-wc2.md * hex extension usage fix * minor comment fix * Remove wc2 in a single commit (#108) * hex extension usage fix * minor comment fix * wallet connect 2 single commit removal * all related active flags renamed to isActive * Fix nft example issues (#109) * refactor wc scenes wip * test scene adjusted to scale for both portrait and landscape mode * demo root scene buttons adjusted * ugui tools removed * ConnectionController adjusted * can send request inversed logic bug bug * logical inversion * wc2 replaced to 2c where needed * demo screen update * method name bugfix for updateChain * logging improvement for test cases * rinkeby changed to goerli * nft contract examples refactoring wip * comment contracts * Wallet connect 2 docs (#106) * migration to 0.6.0 breaking changes migration guide * migration from wc1 to wc2 doc * docs update * Update migration-from-wc1-to-wc2.md * Update migration-from-wc1-to-wc2.md * hex extension usage fix * minor comment fix * nft examples fix wip * fix nft examples wip * abi related bugfix * examples issues fixing in progress * event handling * nft demo scenes fixing wip * final tweaks to the nft example issues * format file * minor naming fixes * files reformatting * Update README.md (#104) * GitHub action to update version in a file (#105) * github action to modify package json * minor fix * handle missing tag case * typo fix * yaml syntax fix * autocommit changes * git commit commands modification * git commit command modification * git commit command modification * update commit command * git commit and push command modified * silence all safe.directory warnings * git commands update * upgrade git push action version * update pushed tag * tags usage removed * set tags to false * run workflow on git push * add git status command * git diff index command added * if else check improved * create file * push to branch * another attempt to push to branch * more logs * branch name reading improvement * get branch name different approach * commit and push tag update to a new branch * push in a different way * push tag separately * move tag to a new commit * tag update workflow improvements * move a git tag to a current commit * git action workflow polished * additional log * additional checkout to be not in a detatched head state * add fetch command * add stashing commands for checkouts * git add command to stage changes for commit * Automated tag update for v0.5.5 * permission related typo fix * rever version * specify ref * remove unused line * Automated tag update for v0.5.5 * do things in different order * revert tag * commands order issue fix * Automated tag update for * bash variable update * revert package json * Automated tag update for v0.5.5 * push tag alternitively * Revert "Automated tag update for v0.5.5" This reverts commit 12f5643. * Automated tag update for v0.5.5 * typo fix * Revert "Automated tag update for v0.5.5" This reverts commit 3dd9531. * Automated tag update for v0.5.5 * different way to move tag * Revert "Automated tag update for v0.5.5" This reverts commit 741f8a4. * Automated tag update for v0.5.5 * alternative way to move tag * Revert "Automated tag update for v0.5.5" This reverts commit 4596733. * Automated tag update for v0.5.5 * tag a particular commit * Revert "Automated tag update for v0.5.5" This reverts commit 55bcd4c. * Automated tag update for v0.5.5 * more detailed logging * Revert "Automated tag update for v0.5.5" This reverts commit a4e5b53. * Automated tag update for v0.5.5 * Revert "Automated tag update for v0.5.5" This reverts commit 0fb9382. * better tag name filter * improved commit name * minor renaming * move py script to different folder * Automated package.json version update for tag v0.5.5 * Revert "Automated package.json version update for tag v0.5.5" This reverts commit aba73ac. --------- Co-authored-by: GitHub Actions <actions@github.com> * remove update nft use case from the grid * ankr to mirage renaming # Conflicts: # Assets/MirageSDK/Examples/UseCases/LoadNFTs/LoadNFTExample.cs # Assets/MirageSDK/Runtime/Core/Implementation/ContractEventSubscriber.cs # Assets/MirageSDK/Runtime/Data/ABIStringLoader.cs # Assets/MirageSDK/package.json * rename variables # Conflicts: # Assets/MirageSDK/Examples/Scripts/WearableNFTExample/WearableNFTExample.cs * ads renaming * package version upgrade * spaces removed * spaces removed * ankr to mirage renaming # Conflicts: # Assets/MirageSDK/Examples/UseCases/LoadNFTs/LoadNFTExample.cs # Assets/MirageSDK/Runtime/Core/Implementation/ContractEventSubscriber.cs # Assets/MirageSDK/Runtime/Data/ABIStringLoader.cs # Assets/MirageSDK/package.json --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> Co-authored-by: alekseeveg <alekseev@ankr.com> Co-authored-by: kwame <kwame@nebulachain.io> Co-authored-by: GitHub Actions <actions@github.com> * minor button positions adjustment * [MC-116] Actualise webgl (#113) * Change chain switch method * Change method name, add jslib for nethereum * Fix bug with nethereum jslib * Remove redundant files, back Unity version * Remove log and add reference * Change chain interface to return empty task --------- Co-authored-by: sidorovk <sidorovk@phxlts.com> * debug contract data loading (#114) * debug contract data loading * additional log * Smart contract call bugfix (#115) * smart contract fixing wip * teardown location bugfix * additional debug logs * remove debug lines * format and compile errors * post review fixes * mirage api removed to be added to widget repo (#116) * Update migration-to-0.6.0.md * Update readme for new sdk name (#119) * Update readme for new sdk name * Fix package name and paths --------- Co-authored-by: sidorovk <sidorovk@phxlts.com> * add switch network prefab fix * wallet entry search minor modification MC-144 (#121) * wallet entry search minor modification MC-144 * downgrade using syntax statement to C# 7..3 * codestyle adjustment * constructor call * Asset Store Adjustment (#122) * wallet entry search minor modification MC-144 * downgrade using syntax statement to C# 7..3 * codestyle adjustment * text mesh pro guide removed * textmeshpro folder renamed for the sake of shader compilation error fix * C# warnings cleanup (required by the asset store) * asset store adjustment in progress * remove unused packages in accordance with asset store requirements * version update in the player settings * remove unused shaders from text mesh pro assets * third party notices file * third party notices meta * third party notices extended * preparation python script completed * replace JsonUtility with Newtonsoft * modify preparation script * third party notices file added * wallet entry search minor modification MC-144 (#121) * wallet entry search minor modification MC-144 * downgrade using syntax statement to C# 7..3 * codestyle adjustment * constructor call * wallet entry search minor modification MC-144 * codestyle adjustment * text mesh pro guide removed * textmeshpro folder renamed for the sake of shader compilation error fix * C# warnings cleanup (required by the asset store) * asset store adjustment in progress * remove unused packages in accordance with asset store requirements * version update in the player settings * remove unused shaders from text mesh pro assets * third party notices file * third party notices meta * third party notices extended * preparation python script completed * replace JsonUtility with Newtonsoft * modify preparation script * third party notices file added * explicit constructor call * rename scripts back to runtime * preparation python script extended * dto namespaces adjustment * namespace missing fix + unused assembly reference fixed --------- Co-authored-by: Kirill Sidorov <38144180+sidorovkirill@users.noreply.github.com> Co-authored-by: alekseeveg <alekseev@ankr.com> Co-authored-by: kwame <kwame@nebulachain.io> Co-authored-by: GitHub Actions <actions@github.com> Co-authored-by: sidorovk <sidorovk@phxlts.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.