Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/1324 buildTemplate/buildDefinition for assets copies non json files into subfolders that have template variable in them + Bug/798 replacing MIDs in JSONs break buildTemplate #1328

Conversation

JoernBerkefeld
Copy link
Contributor

@JoernBerkefeld JoernBerkefeld commented May 16, 2024

PR details

What changes did you make? (Give an overview)

Further details (optional)

...

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • test scripts updated
  • Wiki updated (if applicable)

@JoernBerkefeld JoernBerkefeld added this to the 6.1.0 milestone May 16, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this May 16, 2024
@github-actions github-actions bot added the bug Something isn't working label May 16, 2024
Copy link

github-actions bot commented May 16, 2024

Coverage Report

Commit:94317a3
Base: develop@56e3141

Type Base This PR
Total Statements Coverage  67.27%  67.89%  (+0.62%)
Total Branches Coverage  66.82%  67.36%  (+0.54%)
Total Functions Coverage  77.7%  78.65%  (+0.95%)
Total Lines Coverage  67.27%  67.89%  (+0.62%)
Details (changed files):
File Statements Branches Functions Lines
lib/Builder.js  73.3%  55%  83.33%  73.3%
lib/metadataTypes/Asset.js  64.3%  56.93%  82.5%  64.3%
lib/metadataTypes/MetadataType.js  80.33%  77.19%  74.28%  80.33%
lib/metadataTypes/Query.js  94.21%  81.39%  100%  94.21%

@JoernBerkefeld JoernBerkefeld force-pushed the bug/1324-buildtemplate-for-assets-copies-non-json-files-into-subfolders-that-have-template-variable-in-them branch from 9796b82 to 94317a3 Compare May 16, 2024 12:13
@JoernBerkefeld JoernBerkefeld linked an issue May 16, 2024 that may be closed by this pull request
2 tasks
@JoernBerkefeld JoernBerkefeld changed the title Bug/1324 buildTemplate/buildDefinition for assets copies non json files into subfolders that have template variable in them Bug/1324 buildTemplate/buildDefinition for assets copies non json files into subfolders that have template variable in them + Bug/798 replacing MIDs in JSONs break buildTemplate May 16, 2024
@JoernBerkefeld JoernBerkefeld merged commit a3e87f5 into develop May 16, 2024
9 checks passed
@JoernBerkefeld JoernBerkefeld deleted the bug/1324-buildtemplate-for-assets-copies-non-json-files-into-subfolders-that-have-template-variable-in-them branch May 16, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working e/DevOps EPIC
Projects
None yet
1 participant