Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] replacing MIDs in JSONs break buildTemplate #798

Closed
2 tasks done
JoernBerkefeld opened this issue Mar 12, 2023 · 3 comments · Fixed by #1328
Closed
2 tasks done

[BUG] replacing MIDs in JSONs break buildTemplate #798

JoernBerkefeld opened this issue Mar 12, 2023 · 3 comments · Fixed by #1328
Assignees
@JoernBerkefeld
Labels
bug Something isn't working c/asset COMPONENT c/Generic c/user COMPONENT
Milestone
7.0.0

Comments

@JoernBerkefeld
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

if your markets contain a number and that number happens to match a value directly assigned to a JSON attribute, the result will be invalid json which in turn breaks buildTemplate.

already seen this issue on user and on asset

Expected Behavior

such fields should simply be auto-stringified first to avoid the issue.

Steps To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Run '...'
  4. See error...

Version

4.3.4

Environment

  • OS:
  • Node:
  • npm:

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@JoernBerkefeld JoernBerkefeld added bug Something isn't working c/user COMPONENT c/asset COMPONENT c/Generic labels Mar 12, 2023
@JoernBerkefeld JoernBerkefeld added this to the 4.4.0 milestone Mar 12, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Mar 12, 2023
JoernBerkefeld added a commit that referenced this issue Mar 13, 2023
@JoernBerkefeld
#798: fixes replaced MIDs in JSONs break buildTemplate
d9f8366
JoernBerkefeld added a commit that referenced this issue Mar 14, 2023
@JoernBerkefeld
#798: fixing buildTemplate MID-replacement for asset
4bc3773
JoernBerkefeld added a commit that referenced this issue Mar 14, 2023
@JoernBerkefeld
#798: identify relevant fields for strinfication on asset, event, int…
44254c2 
…eraction
@JoernBerkefeld JoernBerkefeld mentioned this issue Mar 15, 2023
Closed
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Mar 15, 2023 that will close this issue
Bugfix/798 replacing mids in jsons break buildtemplate #807
Closed
4 tasks
@JoernBerkefeld JoernBerkefeld modified the milestones: 5.0.0, 5.0.1 Apr 11, 2023
@JoernBerkefeld JoernBerkefeld modified the milestones: 5.0.1, 5.0.2 May 5, 2023
@JoernBerkefeld JoernBerkefeld mentioned this issue May 30, 2023
Closed
JoernBerkefeld added a commit that referenced this issue May 30, 2023
@JoernBerkefeld
#798: allow stringifying fields that are defined with %. placeholders
6a0c550 
partial solution
JoernBerkefeld added a commit that referenced this issue May 30, 2023
@JoernBerkefeld
#798: simplify stringify definition
0101de9
@JoernBerkefeld JoernBerkefeld modified the milestones: 5.0.3, 5.1.0, 5.1.1 Jun 1, 2023
@JoernBerkefeld JoernBerkefeld modified the milestones: 6.0.1, 6.0.2 Jan 10, 2024
@JoernBerkefeld JoernBerkefeld modified the milestones: 6.0.2, 6.0.3 Jan 18, 2024
@JoernBerkefeld
Copy link
Contributor Author

instead we implemented --noMidSuffix to allow replacing the mid

@JoernBerkefeld JoernBerkefeld closed this as not planned Won't fix, can't repro, duplicate, stale May 14, 2024
@JoernBerkefeld JoernBerkefeld modified the milestones: 6.1.1, 6.1.0 May 14, 2024
@JoernBerkefeld
Copy link
Contributor Author

made memberId a string to keep it working

JoernBerkefeld added a commit that referenced this issue May 16, 2024
@JoernBerkefeld
#798: ensure MID can be templated in memberId field of assets without…
1114c4c 
… breaking json
@JoernBerkefeld JoernBerkefeld mentioned this issue May 16, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request May 16, 2024 that will close this issue
Bug/1324 buildTemplate/buildDefinition for assets copies non json files into subfolders that have template variable in them + Bug/798 replacing MIDs in JSONs break buildTemplate #1328
Merged
4 tasks
@github-actions GitHub Actions
Copy link

Closed by #1328.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/asset COMPONENT c/Generic c/user COMPONENT
Projects
None yet
Milestone
7.0.0
1 participant
@JoernBerkefeld