Use LoadingCache instead of HashMap for CableBusBakedModel #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotMyWing
approved these changes
Jan 30, 2024
AE2-Enthusiast
pushed a commit
to AE2-Enthusiast/AE2-UEL
that referenced
this pull request
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #362
Uses a cache instead of a hashmap to avoid a CME in java 9+.
New impl in this PR vs #362 implements the cache non-statically, since the baked model is only baked once, and allows us to use a LoadingCache instead of a standard cache, giving us access to getUnchecked(). Additionally this no longer necessitates a resource reload listener, since the model will be automatically rebaked on a resource reload, letting GC clean up the old cache instead of needing to clear it on reload