Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Cache instead of HashMap when gathering CableBusBakedModels #362

Closed
wants to merge 1 commit into from
Closed

Use Cache instead of HashMap when gathering CableBusBakedModels #362

wants to merge 1 commit into from

Conversation

Rongmario
Copy link

Directed logging to AELog#error when the cache throws an ExecutionException, feel free to change that if needed.

This was caught when running in Java 9+ where computeIfAbsent is eligible to now throw a ConcurrentModificationException.

@NotMyWing NotMyWing added bug Something isn't working enhancement New feature or request labels Jan 12, 2024
@serenibyss serenibyss mentioned this pull request Jan 28, 2024
Merged
@NotMyWing
Copy link
Member

Superseded by #385.

@NotMyWing NotMyWing closed this Jan 30, 2024
@jchung01 jchung01 mentioned this pull request May 23, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@serenibyss serenibyss

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rongmario @NotMyWing @serenibyss