-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing config #156
Fix parsing config #156
Conversation
43ab5fc
to
138ac53
Compare
AppVeyor fails:
|
Yes... looking wich test fails... Problem is they don't run on my computer... |
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
==========================================
+ Coverage 82.26% 82.57% +0.31%
==========================================
Files 37 37
Lines 3546 3627 +81
Branches 488 488
==========================================
+ Hits 2917 2995 +78
- Misses 491 501 +10
+ Partials 138 131 -7
Continue to review full report at Codecov.
|
@StefH is it ok now? |
Appveyor is fine. I still need to review the code. |
Is this PR still valid ? Or do I need to checkout the other one from you? |
is still valid |
in the other one I only changed the finding of the method |
do I need to fix smth? |
8f19774
to
048e90b
Compare
Is the fix okay? |
I still have to review this change. |
could I help, so we get this merged? |
I could not merge, only you can 😊 |
No description provided.