Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing config #156

Merged
merged 3 commits into from
May 8, 2018
Merged

Conversation

jogibear9988
Copy link
Contributor

No description provided.

@StefH
Copy link
Collaborator

StefH commented Apr 17, 2018

AppVeyor fails:

Starting test execution, please wait...
[xUnit.net 00:00:04.3455977]   Discovering: EntityFramework.DynamicLinq.Tests
[xUnit.net 00:00:04.9032123]   Discovered:  EntityFramework.DynamicLinq.Tests
[xUnit.net 00:00:04.9206366]   Starting:    EntityFramework.DynamicLinq.Tests
The active test run was aborted. Reason: Process is terminated due to StackOverflowException.
Total tests: Unknown. Passed: 9. Failed: 0. Skipped: 0.

@jogibear9988
Copy link
Contributor Author

Yes... looking wich test fails... Problem is they don't run on my computer...

@codecov
Copy link

codecov bot commented Apr 17, 2018

Codecov Report

Merging #156 into master will increase coverage by 0.31%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   82.26%   82.57%   +0.31%     
==========================================
  Files          37       37              
  Lines        3546     3627      +81     
  Branches      488      488              
==========================================
+ Hits         2917     2995      +78     
- Misses        491      501      +10     
+ Partials      138      131       -7
Impacted Files Coverage Δ
...em.Linq.Dynamic.Core/DynamicQueryableExtensions.cs 96.92% <92.85%> (-1.13%) ⬇️
...ystem.Linq.Dynamic.Core/Parser/ExpressionParser.cs 77.51% <0%> (+0.17%) ⬆️
src/System.Linq.Dynamic.Core/Parser/TypeHelper.cs 88.2% <0%> (+0.47%) ⬆️
...c/System.Linq.Dynamic.Core/Tokenizer/TextParser.cs 98.03% <0%> (+1.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73fb6d1...7e9b01a. Read the comment docs.

@jogibear9988
Copy link
Contributor Author

@StefH is it ok now?

@StefH
Copy link
Collaborator

StefH commented Apr 18, 2018

Appveyor is fine. I still need to review the code.

@StefH StefH self-requested a review April 18, 2018 16:59
@StefH
Copy link
Collaborator

StefH commented Apr 19, 2018

Is this PR still valid ? Or do I need to checkout the other one from you?

@jogibear9988
Copy link
Contributor Author

is still valid
the other one is based on this

@jogibear9988
Copy link
Contributor Author

in the other one I only changed the finding of the method

@jogibear9988
Copy link
Contributor Author

do I need to fix smth?

@jogibear9988
Copy link
Contributor Author

Is the fix okay?

@StefH
Copy link
Collaborator

StefH commented Apr 30, 2018

I still have to review this change.

@jogibear9988
Copy link
Contributor Author

could I help, so we get this merged?

@jogibear9988
Copy link
Contributor Author

I could not merge, only you can 😊

@StefH StefH merged commit c17a5eb into zzzprojects:master May 8, 2018
@jogibear9988 jogibear9988 deleted the fixParsingConfig branch May 8, 2018 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants