Add self-signed chain #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewjamesbrown
force-pushed
the
master
branch
4 times, most recently
from
71f88b4 to
ffab944
Compare
Most java applications require both the certificate and the intermediate chain to be part of the keystore; this adds the intermediate certificate chain to support these apps.
andrewjamesbrown
force-pushed
the
master
branch
from
a9308dc to
3782b62
Compare
|
@zuazo it looks like only Travis is running CI... any suggestions on how to run the integration tests using Circle? I've run the modified ones on my machine (which pass), but running them all is a PITA. Thanks! |
|
I have enabled CircleCI builds on forked PRs. I didn't know it is disabled by default. Anyway, Travis CI seem to be failing due to this issue: I tried re-running the job, but it's still not fixed. After this is fixed, I'm going to try to run Circle CI on your branch locally. |
zuazo
added
enhancement
Type: Enhancement
Status: Maintainer Review Needed
and removed
enhancement
labels
|
Merged! Thank you @andrewjamesbrown! 😃 |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add self-signed chain methods to ensure that CI passes. Currently the self-signed chain simply returns
nil; this could be enhanced later but works for now.