Connector server support to adding a note #5064
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pass canUserAddNote flag in ping response to tell the connector that it should display a note field - when the connector sends a note, create a child note item if it does not yet exist and set its content. If the child item for user-added notes is already created, update it - if the connector sends an empty note, user-added child note item is deleted - record child notes added by the user in _userAddedNotes cache to distinguish between user added notes and notes added by the connector automatically - if the target library changes, child note items are moved to the new library as well. _userAddedNotes will be updated to reflect new itemIDs - if there are multiple toplevel items being added, the note is added to all of them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
canUserAddNoteflag in ping response to tell the connector that it should display a note field_userAddedNotescache to distinguish between user added notes andnotes added by the connector automatically
_userAddedNoteswill be updated to reflect new
itemIDs