Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Improved generic translation #1897

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

[DO NOT MERGE] Improved generic translation #1897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b6b8c50
Improved generic translation
mrtcode Mar 4, 2019
8940a1a
normalize -> asciify
AbeJellinek Mar 21, 2024
0f46010
Generic: Update DOI translator ID
AbeJellinek Mar 21, 2024
00a778e
Generic: Use non-"webpage" item type when found
AbeJellinek Mar 21, 2024
ecc1ddd
Generic: Only use head DOIs when found?
AbeJellinek Mar 21, 2024
f7f28d7
Generic: Add all tests from EM, plus one for item type change
AbeJellinek Mar 21, 2024
2d572e2
Update tests from EM
AbeJellinek Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Embedded Metadata.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,10 +651,10 @@ function addOtherMetadata(doc, newItem) {
function addLowQualityMetadata(doc, newItem) {
// if we don't have a creator, look for byline on the page
// but first, we're desperate for a title
if (!newItem.title) {
Z.debug("Title was not found in meta tags. Using document title as title");
newItem.title = doc.title;
}
// if(!newItem.title) {
// Z.debug("Title was not found in meta tags. Using document title as title");
// newItem.title = doc.title;
// }

if (newItem.title) {
newItem.title = newItem.title.replace(/\s+/g, ' '); // make sure all spaces are \u0020
Expand Down
Loading
Loading