refactor update the project / workflow contents #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se#2169)" (zooniverse#2267)" This reverts commit 69abc6c.
ensure the parent model gets the updated_at timestamp touched to invalidate any cache keys
houndci-bot
reviewed
Apr 3, 2017
| yield ps if block_given? | ||
| content = ps.slice(*content_fields) | ||
| content[:language] = ps[:primary_language] | ||
| if ps.has_key? :urls |
There was a problem hiding this comment.
Use Hash#key? instead of Hash#has_key?.
| end | ||
| reject_live_project_changes(workflow, update_params) | ||
| def build_update_hash(update_params, resource) | ||
| if update_params.has_key? :tasks |
There was a problem hiding this comment.
Use Hash#key? instead of Hash#has_key?.
4 tasks
camallen
commented
Apr 3, 2017
| resource.tags = tags unless tags.nil? | ||
|
|
||
| if !content_attributes.blank? || !tags.nil? | ||
| resource.updated_at = Time.zone.now |
There was a problem hiding this comment.
I should probably just allow the tag belongs_to to touch the project resource here instead of manually setting the TS for the save action.
marten
approved these changes
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2212, second attempt at #2169
Refactor the controller actions to not require the content relations in the extended_cache_key. Also ensure we touch the parent translated resource when updating the content child relations, think just content updates like workflow task text changes.
Review checklist
apiary.apibfile?