Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Inline simple physical layout info in new shield guide #2827

Merged

Conversation

caksoylar
Copy link
Contributor

As discussed on Discord. Also snuck in a broken anchor fix and a consistency fix in physical layouts page.

@caksoylar caksoylar added the documentation Improvements or additions to documentation label Feb 17, 2025
@caksoylar caksoylar requested a review from a team as a code owner February 17, 2025 20:49
@caksoylar caksoylar force-pushed the docs/new-shield-simple-physical-layout branch from 165c9c9 to aa74683 Compare February 17, 2025 21:39
Copy link
Contributor

@nmunnich nmunnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve this in advance of you fixing the prettier issue.

@caksoylar caksoylar force-pushed the docs/new-shield-simple-physical-layout branch from aa74683 to 01d476a Compare February 17, 2025 23:53
@caksoylar caksoylar merged commit 8575fc8 into zmkfirmware:main Feb 17, 2025
7 checks passed
@caksoylar caksoylar deleted the docs/new-shield-simple-physical-layout branch February 17, 2025 23:59
tjmitchem pushed a commit to tjmitchem/zmk that referenced this pull request Feb 20, 2025
…ware#2827)

docs: Inline simple physical layouts in new shield guide

docs: Fix broken anchor in module creation

docs: Make physical layout transform label consistent and comment
nmunnich pushed a commit to nmunnich/zmk that referenced this pull request Feb 27, 2025
…ware#2827)

docs: Inline simple physical layouts in new shield guide

docs: Fix broken anchor in module creation

docs: Make physical layout transform label consistent and comment
nmunnich pushed a commit to nmunnich/zmk that referenced this pull request Feb 27, 2025
…ware#2827)

docs: Inline simple physical layouts in new shield guide

docs: Fix broken anchor in module creation

docs: Make physical layout transform label consistent and comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants