-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Inline simple physical layout info in new shield guide #2827
Merged
caksoylar
merged 3 commits into
zmkfirmware:main
from
caksoylar:docs/new-shield-simple-physical-layout
Feb 17, 2025
Merged
docs: Inline simple physical layout info in new shield guide #2827
caksoylar
merged 3 commits into
zmkfirmware:main
from
caksoylar:docs/new-shield-simple-physical-layout
Feb 17, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmunnich
reviewed
Feb 17, 2025
165c9c9
to
aa74683
Compare
nmunnich
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to approve this in advance of you fixing the prettier issue.
aa74683
to
01d476a
Compare
tjmitchem
pushed a commit
to tjmitchem/zmk
that referenced
this pull request
Feb 20, 2025
…ware#2827) docs: Inline simple physical layouts in new shield guide docs: Fix broken anchor in module creation docs: Make physical layout transform label consistent and comment
nmunnich
pushed a commit
to nmunnich/zmk
that referenced
this pull request
Feb 27, 2025
…ware#2827) docs: Inline simple physical layouts in new shield guide docs: Fix broken anchor in module creation docs: Make physical layout transform label consistent and comment
nmunnich
pushed a commit
to nmunnich/zmk
that referenced
this pull request
Feb 27, 2025
…ware#2827) docs: Inline simple physical layouts in new shield guide docs: Fix broken anchor in module creation docs: Make physical layout transform label consistent and comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Discord. Also snuck in a broken anchor fix and a consistency fix in physical layouts page.