Added a fix for the value mapping of an array of objects

[Jack12816]

- What is it good for

I stumbled over the version 5 to 6 upgrade issue (#398) and this is an approach to solve the issue.

- What I did

I debugged the cur property to be an array and the p[:name] access resulted in an TypeError: no implicit conversion of String into Integer. Now we detect this situation and pick the first object of the array. Furthermore we add an additional empty string to the scopes array as an indicator. This results in parameter names like this: props[pictures][][id].

- A picture of a cute animal (not mandatory but encouraged)

[oestrich]

Thanks!

[anklos]

Hi there,

I used the master branch in my Gemfile, however I am still experiencing the issue when submit the params like this:

params = {
        booking: {
          sessions: [
              {
                court_id: court_1.id,
                time: [20,21],
                date: '2017-03-02'
              },
              {
                court_id: court_2.id,
                time: [20,21,22],
                date: '2017-03-02'
              }
            ]
          }
        }

      do_request params

i debugged around the same place of the pull request. As param[:scope] << '' is introduced, it throws an error in the line [*p[:scope]].each { |scope| cur = cur && (cur[scope.to_sym] || cur[scope.to_s]) } when the scope is an empty string.

In my example, cur is [{:court_id=>22265, :time=>[20, 21], :date=>"2017-03-02"}, {:court_id=>22266, :time=>[20, 21, 22], :date=>"2017-03-02"}] and cur[scope.to_sym] would throw *** TypeError Exception: no implicit conversion of Symbol into Integer when the scope is ''

Any suggestion? Thank you.

[trevorrjohn]

Yeah I don't think this fixed it, here is a spec master...trevorrjohn:show-broken-spec

 % bundle exec rspec spec/dsl_spec.rb:426
Run options: include {:locations=>{"./spec/dsl_spec.rb"=>[426]}}
F

Failures:

  1) Order proper query_string serialization GET /orders scope with array of hashes param parsed properly
     Failure/Error: param[:scope] << ''

     NoMethodError:
       undefined method `<<' for :search:Symbol
       Did you mean?  <
     # ./spec/dsl_spec.rb:426:in `block (5 levels) in <top (required)>'

Finished in 0.00842 seconds (files took 0.59245 seconds to load)
1 example, 1 failure

Failed examples:

rspec ./spec/dsl_spec.rb:420 # Order proper query_string serialization GET /orders scope with array of hashes param parsed properly

[diegotoral]

I am dealing with the same problem with version 6.1.0.

Just updated a spec to include nested attributes to my params hash and it throws TypeError: no implicit conversion of String into Integer.

[Uysim]

@oestrich @Jack12816 Do you know what we still face this problem after merged?
Seem like you missed this info

[jakehow]

@Uysim please open a new issue and/or PR with details if you have a fix.

[ngoral]

The problem anyone's having is here.
This line changes params, so next time we use example { do_request }, it is called with altered scope. Causing line 32 to fail.
If we move these lines into a loop, we'll go deeper and deeper, ending up with as many []-s as we had do_request-s. E.g. props[pictures][][][id] if we called do_request inside a group for request twice

I would suggest changing the code in such way that if we want to do nested arrays in parameter, we should use '' there. Like so:

parameter :pictures, type: :array
parameter :id, scope: [:pictures, '']

I can do it, just need some kind of approval on it =)

Auto-adding [] for array scopes of course would be nice, but I can't see a good way of doing it right now (if you do, you are very welcome). I think it should be done somewhere in writers, though, not changing user-defined params.

Or we can just use plain old scope: 'pictures[]'

I would revert this PR, 'cause it seems to break work with any array parameters (see @jsmartt code in #462 )