Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Union{Nothing, T} #63

Merged
merged 4 commits into from
Jul 3, 2021
Merged

Add support for Union{Nothing, T} #63

merged 4 commits into from
Jul 3, 2021

Conversation

ziotom78
Copy link
Owner

@ziotom78 ziotom78 commented Jul 3, 2021

This small PR adds basic support for maps based on the type Union{Nothing, T} to signal missing pixels. It's a more natural and effective way than using UNSEEN, and it requires very few adjustments to the code:

  • A special constructor for HealpixMap
  • Basic support for map I/O (currently only floating-point values are supported, because I'm lazy!)
  • Documentation
  • Tests

@codecov
Copy link

codecov bot commented Jul 3, 2021

Codecov Report

Merging #63 (e81932c) into master (5d60214) will increase coverage by 0.20%.
The diff coverage is 92.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   86.30%   86.50%   +0.20%     
==========================================
  Files          18       18              
  Lines         942      956      +14     
==========================================
+ Hits          813      827      +14     
  Misses        129      129              
Impacted Files Coverage Δ
src/map_io.jl 90.00% <91.30%> (+2.06%) ⬆️
src/map.jl 63.33% <100.00%> (+2.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d60214...e81932c. Read the comment docs.

@ziotom78 ziotom78 merged commit d90a48b into master Jul 3, 2021
@ziotom78 ziotom78 deleted the nothingness branch July 3, 2021 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant