Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch consumerGroupMetaData less often #1431

Closed
erikvanoosten opened this issue Jan 7, 2025 · 1 comment · Fixed by #1464
Closed

Fetch consumerGroupMetaData less often #1431

erikvanoosten opened this issue Jan 7, 2025 · 1 comment · Fixed by #1464
Labels
good first issue Good for newcomers

Comments

@erikvanoosten
Copy link
Collaborator

erikvanoosten commented Jan 7, 2025 •
edited
Loading

Currently, we fetch consumerGroupMetaData after every poll (see method offerRecordsToStreams in Runloop). This metadata only changes after a rebalance so fetching it that often is overhead.

Fix this by only fetching consumerGroupMetaData after a rebalance.
@erikvanoosten erikvanoosten added the good first issue Good for newcomers label Jan 9, 2025
@vermas7988 vermas7988 mentioned this issue Feb 12, 2025
Merged
@vermas7988
Copy link
Contributor

vermas7988 commented Feb 12, 2025 •
edited
Loading

I raised a PR for above mentioned changes

erikvanoosten pushed a commit that referenced this issue Feb 17, 2025
@vermas7988
Fetch consumerGroupMetaData less often (#1464)
a51fbae 
The consumer group metadata only changes after a rebalance, yet
currently we retrieve it after every poll. This change only fetches the
consumer group metadata after a rebalance.

Fixes #1431.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fetch consumerGroupMetaData less often vermas7988/zio-kafka
2 participants
@erikvanoosten @vermas7988