Prerequisites for FAISS HNSW #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
…gned Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #731 +/- ##
=========================================
+ Coverage 0 71.97% +71.97%
=========================================
Files 0 70 +70
Lines 0 5160 +5160
=========================================
+ Hits 0 3714 +3714
- Misses 0 1446 +1446 |
liliu-z
approved these changes
Jul 29, 2024
| template <class C> | ||
| inline void heap_push( | ||
| size_t k, | ||
| std::pair<typename C::T, typename C::TI>* bh, |
There was a problem hiding this comment.
Curios about why we need to add another function with pair
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderguzhva, liliu-z The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A collection of small tweaks that might be needed in the future.
nhops, which is a number of different nodes visited through a single query searchPQDecoder8std::pair<dis,ids>formatHNSW::upper_beam != 1search use caseHNSW::MinimaxHeap::pop_minAdditionally, fixes a bug in
ScalarQuantizerCoder_avx512Corresponding baseline Faiss PR: facebookresearch/faiss#3692
/kind improvement