Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Tuya local temp calibration, remove setpoint min/max #3877

Merged
merged 3 commits into from
Feb 16, 2025

Conversation

prairiesnpr
Copy link
Collaborator

@prairiesnpr prairiesnpr commented Feb 16, 2025

Proposed change

Ensure we use tuya_number for all local_temperature_calibrtation entities.

Updates Tuya TRVs to use abs_min_heat_setpoint_limit and abs_max_heat_setpoint_limit to no longer create unnecessary config entities from ZHA.
Adds min_heat_setpoint_limit and max_heat_setpoint_limit to unsupported attributes, for TRVs to remove them on previously paired devices.

Adds tests.

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.94%. Comparing base (2a96ada) to head (33f603b).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3877   +/-   ##
=======================================
  Coverage   90.94%   90.94%           
=======================================
  Files         326      326           
  Lines       10585    10589    +4     
=======================================
+ Hits         9626     9630    +4     
  Misses        959      959           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added Tuya Request/PR regarding a Tuya device bugfix This PR fixes a bug labels Feb 16, 2025
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@TheJulianJES TheJulianJES changed the title Clean up local temperature calibration Improve Tuya local temp calibration, remove setpoint entities Feb 16, 2025
@TheJulianJES TheJulianJES changed the title Improve Tuya local temp calibration, remove setpoint entities Improve Tuya local temp calibration, remove setpoint min/max Feb 16, 2025
@TheJulianJES TheJulianJES merged commit 947a8ae into zigpy:dev Feb 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR fixes a bug Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants