Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tuya temp/humidity sensor quirks (_TZE200_upagmta9, ...) #3817

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

prairiesnpr
Copy link
Collaborator

Proposed change

Add Tuya tze200 cirvgep4 and combine quirks to match z2m.

See: https://github.com/Koenkk/zigbee-herdsman-converters/blob/09cfce5153d3931c7cc009aa3ae3107d9b394f5c/src/devices/tuya.ts#L1073

Additional information

Closes: #2577
Closes: #2854
Closes: #2304
Closes: #3260
Closes: #2725
Closes: #2929

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.91%. Comparing base (730f0a8) to head (69181b3).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3817      +/-   ##
==========================================
- Coverage   90.91%   90.91%   -0.01%     
==========================================
  Files         325      325              
  Lines       10567    10566       -1     
==========================================
- Hits         9607     9606       -1     
  Misses        960      960              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Jan 31, 2025
@TheJulianJES TheJulianJES changed the title Add Tuya tze200 cirvgep4 Fix Tuya temperature/humidity sensor quirks Jan 31, 2025
@TheJulianJES TheJulianJES changed the title Fix Tuya temperature/humidity sensor quirks Fix Tuya temp/humidity sensor quirks (_TZE200_upagmta9, ...) Jan 31, 2025
@TheJulianJES TheJulianJES merged commit 8b3560e into zigpy:dev Jan 31, 2025
9 checks passed
@prairiesnpr prairiesnpr deleted the add-_TZE200_cirvgep4 branch January 31, 2025 23:55
@grericht
Copy link

grericht commented Feb 2, 2025

Can someone please explain to me what is happening here? I have installed these thermostats in all my rooms for display and heating control. They work reasonably well under mqtt but when I press the button they no longer send any data. I had the same problem under zha and also had difficulty integrating them at all. What is the current status and will there be a solution for the devices or do I have to buy new ones?
EDIT: I have integrated a thermometer with zha but it doesn't show any entities? Is it already implemented or do I need to set up a quirk?

@prairiesnpr
Copy link
Collaborator Author

EDIT: I have integrated a thermometer with zha but it doesn't show any entities? Is it already implemented or do I need to set up a quirk?

This hasn't made it to HA yet. There is a small chance it will make 2025.2, but more likely it will be 2025.3.

@grericht
Copy link

grericht commented Feb 3, 2025

Thank you for the answer. That means that I no longer need a quirk from HA2025.03 onwards?! Will it only be implemented when everything works? Including the lighting button, which doesn't work in any version yet?
Is there a current quirk that I can test?

@prairiesnpr
Copy link
Collaborator Author

Thank you for the answer. That means that I no longer need a quirk from HA2025.03 onwards?! Will it only be implemented when everything works? Including the lighting button, which doesn't work in any version yet? Is there a current quirk that I can test?

You will no longer need a custom quirk. You can test this PR as a custom quirk, but will need to be on 2025.2 to do so. As far as the light, I don't think this supports that, which specific device do you have?

@grericht
Copy link

grericht commented Feb 3, 2025

i have TZE200_cirvgep4
actually zha+quirk and z2m dont send any data after i push the button

@prairiesnpr
Copy link
Collaborator Author

i have TZE200_cirvgep4 actually zha+quirk and z2m dont send any data after i push the button

If z2m hasn't figured this out, we would need to capture traffic with the Tuya hub to understand exactly what the device expects as a reply.

@grericht
Copy link

grericht commented Feb 3, 2025

i dont have a tuya hub. i use zha and z2m in home assistant.
for z2m it seem someone found a solution using an automation. but for me this seem not to work: Koenkk/zigbee2mqtt#17008 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment