Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Tuya door quirk to v2, add tuya_vibration #3796

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

prairiesnpr
Copy link
Collaborator

@prairiesnpr prairiesnpr commented Jan 28, 2025

Proposed change

Converts the quirk for _TZE200_kzm5w4iz to v2, updates tests and add tuya_vibration to TuyaQuirkBuilder.
This PR also refactors sensors a bit, moving door sensors into tuya_contact.py.

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.89%. Comparing base (ab4e4f5) to head (d8dcc84).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3796      +/-   ##
==========================================
- Coverage   90.91%   90.89%   -0.02%     
==========================================
  Files         324      324              
  Lines       10562    10543      -19     
==========================================
- Hits         9602     9583      -19     
  Misses        960      960              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@TheJulianJES TheJulianJES changed the title Convert door quirk to v2 add tuya_vibration Convert Tuya door quirk to v2, add tuya_vibration Jan 28, 2025
@TheJulianJES TheJulianJES merged commit 4d83f9c into zigpy:dev Jan 28, 2025
8 of 9 checks passed
@prairiesnpr prairiesnpr deleted the tuya-door-v2 branch January 28, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants