Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tuya siren manufacturer/model _TZE204_hcxvyxa5 #3760

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

TheJulianJES
Copy link
Collaborator

Proposed change

This removes a duplicate manufacturer/model tuple for a Tuya siren "_TZE204_hcxvyxa5", "TS0601" and changes the manufacturer/model info to _TZE204_hcxvyxa5 for the "Tuya ZA03" siren quirk.

Additional information

Fixes part of the issues detected in: #3758 (comment)

It seems like the manufacturer/model info was just copy-pasted from the "Neo NAS-AB02B2" siren to the "Tuya ZA03" siren, but the rest is correct.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@TheJulianJES TheJulianJES added Tuya Request/PR regarding a Tuya device bugfix This PR fixes a bug labels Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.13%. Comparing base (0ca585f) to head (2985f10).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #3760   +/-   ##
=======================================
  Coverage   90.13%   90.13%           
=======================================
  Files         320      320           
  Lines       10473    10473           
=======================================
  Hits         9440     9440           
  Misses       1033     1033           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES merged commit 2aad9e1 into zigpy:dev Jan 23, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR fixes a bug Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant