-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tuya rain sensor _TZ3210_tgvtvdoc
#3656
Add Tuya rain sensor _TZ3210_tgvtvdoc
#3656
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3656 +/- ##
=======================================
Coverage 90.96% 90.97%
=======================================
Files 327 328 +1
Lines 10608 10619 +11
=======================================
+ Hits 9650 9661 +11
Misses 958 958 ☔ View full report in Codecov by Sentry. |
I just tried your chages as a custom quirk in HASS looks like the battery state isn't working with it. |
I didn't implement the battery, what type of battery does it use? |
it has an internal battery thats charaged via solar, i think its a percentage value on tuya datapoint 4 |
I'm away from PC today, you could try adding |
cbe1574
to
ca7a3d5
Compare
9b2f241
to
9811ed9
Compare
9811ed9
to
85dd098
Compare
85dd098
to
9a8d178
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems also fine otherwise
state_class=SensorStateClass.MEASUREMENT, | ||
unit=UnitOfElectricPotential.MILLIVOLT, | ||
entity_type=EntityType.STANDARD, | ||
fallback_name="Rain intensity", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we might wanna change this to "Voltage"
to reflect the HA name, since that's what HA will use.
But not important for now, as it won't be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
_TZ3210_tgvtvdoc
Proposed change
Adds: _TZ3210_tgvtvdoc
Based on: #3475
Closes: #3249
Requires a resolution to zigpy/zha#327
Additional information
Requires: #3643
Checklist
pre-commit
checks pass / the code has been formatted using Black