Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Schneider Electric Thermostats #3473

Merged
merged 2 commits into from
Nov 24, 2024
Merged

Conversation

uvNikita
Copy link
Contributor

@uvNikita uvNikita commented Oct 29, 2024

Proposed change

Adds support to some Electric Thermostats based on the zigbee specs published here: Koenkk/zigbee2mqtt#23739

Specs: RTC-6754012INT-cFMT_16A_F_Zigbee-29.pdf

For now, I added two most interesting attributes for me:

  • Metering/fixed_load_demand. It can be set to a nominal consumption of the heating. After setting this value, thermostat starts to output summation delivered estimated based on specified load.
  • TemperatureMeasurement/temperature_sensor_type. Can be used to modify external (floor) sensor type specified during initial installation.

Reference to the original issue #1705

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@uvNikita
Copy link
Contributor Author

I wasn't sure if I should add it under zhaquirks/schneiderelectric or zhaquirks/schneider

@uvNikita uvNikita force-pushed the se/thermostat branch 2 times, most recently from 0a3bb0f to 831eb4e Compare October 29, 2024 21:28
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.61%. Comparing base (bc2aa90) to head (658b724).
Report is 18 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3473      +/-   ##
==========================================
+ Coverage   89.44%   89.61%   +0.17%     
==========================================
  Files         311      313       +2     
  Lines       10031    10218     +187     
==========================================
+ Hits         8972     9157     +185     
- Misses       1059     1061       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@uvNikita uvNikita force-pushed the se/thermostat branch 3 times, most recently from d876b1c to 2a26935 Compare October 29, 2024 21:52
@uvNikita uvNikita force-pushed the se/thermostat branch 4 times, most recently from afa90ac to 7e23b00 Compare November 20, 2024 20:11
@uvNikita
Copy link
Contributor Author

I went ahead and added the rest of the clusters, custom attributes and commands from the spec file.

@uvNikita
Copy link
Contributor Author

@TheJulianJES I think this one should be ready for review :)

I think everything from spec is implemented. The only thing to add I can think of is home assistant numbers, sensors etc. For now, whatever I add gets _none suffix in it's entity id, not sure how to fix it yet.

@TheJulianJES
Copy link
Collaborator

I think everything from spec is implemented. The only thing to add I can think of is home assistant numbers, sensors etc. For now, whatever I add gets _none suffix in it's entity id, not sure how to fix it yet.

With HA Core 2024.11, ZHA should fall back to the fallback_name if it cannot find the value for a translation key.
We'll add the translation key values to Home Assistant Core in the ZHA dependency bump, based on the fallback_name in the quirk.

@TheJulianJES TheJulianJES added the smash This PR is close to be merged soon label Nov 24, 2024
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@TheJulianJES TheJulianJES merged commit f239f30 into zigpy:dev Nov 24, 2024
9 checks passed
@uvNikita uvNikita deleted the se/thermostat branch November 25, 2024 08:42
@iamdabe
Copy link

iamdabe commented Dec 27, 2024

Can this be extended to handle the Image CCTFR6700 Schneider Electric's Wiser - Electric heating actuator- 16A - Pilot wire CCTFR6700 too?

https://www.zigbee2mqtt.io/devices/CCTFR6700.html

The device requires pilot wire setting and method to set temperature to work correctly. Currently it is detected but does not work correctly.

https://community.home-assistant.io/t/schneider-electric-cctfr6700-16a-relay-external-temperature-sensor/341537/9?u=iamdabe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smash This PR is close to be merged soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants