-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Giex GX02 quirk to V2 #3394
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3394 +/- ##
==========================================
+ Coverage 89.35% 89.37% +0.02%
==========================================
Files 308 308
Lines 9978 9990 +12
==========================================
+ Hits 8916 8929 +13
+ Misses 1062 1061 -1 ☔ View full report in Codecov by Sentry. |
907a4d3
to
693aa6d
Compare
693aa6d
to
4e26fc7
Compare
That might have been fixed by the PR below. Would be great to get confirmation on that (or that it didn't break anything 😄): |
Can confirm, it was created on joining. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Proposed change
Convert GX02 Quirk to a V2 Quirk. Add additional functionality.
Additional information
or Add Timestamp Sensor zha#224
Setting on board schedule.
Closes: #3052, Closes: #3209
Checklist
pre-commit
checks pass / the code has been formatted using Black