-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quirk for Ikea TRETAKT Smart Plug #3145
Quirk for Ikea TRETAKT Smart Plug #3145
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3145 +/- ##
==========================================
+ Coverage 88.14% 88.15% +0.01%
==========================================
Files 299 300 +1
Lines 9389 9398 +9
==========================================
+ Hits 8276 8285 +9
Misses 1113 1113 ☔ View full report in Codecov by Sentry. |
IKEA is using light level with On/Off then doing direct pairing of there controllers and they looks using the same cluster setting doing coordinator paring. Good work done !!! |
@TheJulianJES Shall we not having the manufacture cluster in the replacement so not loosing future possible functions ? |
BTW, new cluster in this device: 0xFC85 |
Yes i was seen it and its not used in any github repros for Zigbee. zha-device-handlers/zhaquirks/ikea/__init__.py Lines 18 to 19 in bfbfb48
|
@MattWestb Is something else expected from me or am I just waiting for the merge? |
Its depend of the maintainers if they like have some changes made or if no needed the shall merging it sooner or later. |
Thanks for the PR! I think we can simplify this with quirks v2 now, so we don't need to match the whole signature. You can just install it as a custom quirk. See if the same behavior (of removing the @MattWestb You're also welcome to test that quirk of course! |
Continue in: #3174 |
Proposed change
The new Ikea plug exposes entities that are not correct and do not work, this quirk solves them by exposing only the parameters of a plug.
Checklist
pre-commit
checks pass / the code has been formatted using Black