Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test disabled: atomicrmw with floats #4457

Closed
andrewrk opened this issue Feb 14, 2020 · 0 comments · Fixed by #8922
Closed

test disabled: atomicrmw with floats #4457

andrewrk opened this issue Feb 14, 2020 · 0 comments · Fixed by #8922
Labels
arch-aarch64 64-bit ARM arch-arm 32-bit ARM arch-mips 32-bit and 64-bit MIPS arch-riscv 32-bit and 64-bit RISC-V bug Observed behavior contradicts documented or intended behavior
Milestone
0.8.0

Comments

@andrewrk
Copy link
Member

zig/test/stage1/behavior/atomics.zig

Lines 148 to 152 in 40b9db7

test "atomicrmw with floats" {
if (builtin.arch == .aarch64 or builtin.arch == .arm or builtin.arch == .riscv64)
return error.SkipZigTest;
testAtomicRmwFloat();
}

Related:
@andrewrk andrewrk added bug Observed behavior contradicts documented or intended behavior arch-aarch64 64-bit ARM arch-arm 32-bit ARM arch-riscv 32-bit and 64-bit RISC-V labels Feb 14, 2020
@andrewrk andrewrk added this to the 0.7.0 milestone Feb 14, 2020
@andrewrk andrewrk mentioned this issue Feb 14, 2020
Open
9 tasks
@vielmetti vielmetti mentioned this issue Mar 10, 2020
Open
6 tasks
@LemonBoy LemonBoy mentioned this issue Mar 11, 2020
Merged
3 tasks
@andrewrk andrewrk added the arch-mips 32-bit and 64-bit MIPS label Mar 12, 2020
@andrewrk andrewrk modified the milestones: 0.7.0, 0.8.0 Oct 30, 2020
@andrewrk andrewrk modified the milestones: 0.8.0, 0.9.0 Nov 6, 2020
@andrewrk andrewrk modified the milestones: 0.9.0, 0.10.0 May 19, 2021
LemonBoy added a commit to LemonBoy/zig that referenced this issue May 28, 2021
@LemonBoy
stage1: Fix for atomicrmw xchg on fp types
e1cb3f1 
Bitcast the pointer and operands to integer types having the same size,
working around LLVM inability to lower a LL/SC operation when the
operands have floating-point types (and are reasonably sized).

Closes ziglang#4457
@LemonBoy LemonBoy mentioned this issue May 28, 2021
Merged
andrewrk pushed a commit that referenced this issue May 28, 2021
@LemonBoy @andrewrk
stage1: Fix for atomicrmw xchg on fp types
d3fb9f9 
Bitcast the pointer and operands to integer types having the same size,
working around LLVM inability to lower a LL/SC operation when the
operands have floating-point types (and are reasonably sized).

Closes #4457
@andrewrk andrewrk modified the milestones: 0.10.0, 0.8.0 May 28, 2021
@Vexu Vexu mentioned this issue Jun 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-aarch64 64-bit ARM arch-arm 32-bit ARM arch-mips 32-bit and 64-bit MIPS arch-riscv 32-bit and 64-bit RISC-V bug Observed behavior contradicts documented or intended behavior
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

stage1: Fix for atomicrmw xchg on fp types LemonBoy/zig
1 participant
@andrewrk