-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(master): release 1.2.1 #251
Conversation
f399030
to
e0b5cda
Compare
I have tested this version on multiple os platforms. This should have everything minus the auto release of version files though those can be found here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you much @sekwah41 for your effort in this small project. You are so amazing 🙇♂️
@roldanjr ill look into that after work tonight, likely an issue with updating electron and needing to rename the variable or something. The mains screens and app should work fine still though :) |
@roldanjr turns out the image was just referenced wrong. I think the images must have been renamed or edited because I made the change to that file name back in 2020 :P |
The fullscreen break seems not working properly on Mac OS. |
For some reason on windows if you click on it full screens as if it's some weird delayed action then escape minimizes it. I'll take a look and see why it doesn't seem to work without interaction. |
e0b5cda
to
170a8cc
Compare
Seems the issue on mac is that it doesnt respect the code fully. Windows its fine. |
0360b74
to
b5a7268
Compare
you removed win?.setResizable(flag); in recent update |
I've got a task on my list to look at this, this weekend. The issue is any order I can see atm seems to break it on one of the other os'. If you set it in a different order it seems to break weirdly in this version of electron so I was going to re-do it once I had all three running at once and see if I can make a uniform one which works across all the systems. For some reason mac just doesn't properly fullscreen if the order it used to work was used but ubuntu or windows would be fine. Or alter it to work on mac and suddenly windows doesn't resize itself but has the fullscreen UI. |
86b82d1
to
adb6953
Compare
The release is blocked by #261 as there were issues relating to resizing I disabled the logic enabling and disabling the resizing. For some reason, mac, ubuntu, and windows all seem to act differently or do not apply the setting before the next function is called altering the size. This leaves two options.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check comments about resizing issue
adb6953
to
7590f96
Compare
Will take a look at fixing some of these things and doing a quick release before trying the migration to Tauri. Though a few of these issues were very fiddly as they seem to alter behaviour that bugs in different ways on different operating systems at least for the resizing issues. Though I will look into altering the CSS to allow resizing manually to work as we would be able to take that feature across to Tauri too. |
7590f96
to
47b632e
Compare
47b632e
to
81296c0
Compare
🤖 I have created a release beep boop
1.2.1 (2022-12-20)
Changes to Existing Features 🔧
Miscellaneous Chores
Features ✨
Bug Fixes 🐛
This PR was generated with Release Please. See documentation.