Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(master): release 1.2.1 #251

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 24, 2022

🤖 I have created a release beep boop

1.2.1 (2022-12-20)

Changes to Existing Features 🔧

Miscellaneous Chores

  • this is just to try and trigger the right release version (2f6fb49)

Features ✨

  • added compact mode (#178) (c057c11)
  • allow other UI to scale to the new resizeable mode (dee69fe)
  • allow the window to be resized and app to scale (9bd0128)
  • compact mode: prevent user from resizing the window (dd69232)
  • website: update downloadable installer version (cd1b1cd)

Bug Fixes 🐛

  • app icon on mac (ce12ace)
  • app: invalid .desktop category mentioned here #127 (534db41)
  • app: try to fix issue #106 (1061494)
  • broken styles during compact mode (b142a47)
  • bump version for main package.json (was resulting in wrong release version) (c1530ce)
  • center add card element creating started (6d4ce16)
  • change help links cursor to pointer (930e79a), closes #167
  • don't close cards when clicking as its easy to lose info (8394249)
  • drag logic for logo on title bar (460090b)
  • exiting fullscreen error on linux (a08ec7a)
  • explicitly define security policy to stop electron complaining (d19fead)
  • flag extra files for version bumps (a9b2a31)
  • fullscreen break escape key issue (b4affbb)
  • lower electron version as bumping causes release build failures (dff7116)
  • lower uuid version to fix lib export issue (fd30315)
  • mac fullscreen break (42dd82d)
  • make tasks not edit when clicking contained links (7b4de89)
  • make the settings menu vertically resize (eec4ef0)
  • min size not respected when coming out of compact mode (1d3171f)
  • range slider visual bug on window resized (365fda3)
  • re-enable resizeable as it may be causing issues on ubuntu (e7befeb)
  • styling issues with compact mode + fullscreen (3cb1725)
  • task links not opening in new windows (a32807f)
  • timer task preview size (5ed1275)
  • update to electron 18 to avoid gpu issues on certain linux distros (bcd4755)
  • website: force render on client-side (#206) (fb9f111)
  • website: remove canonical link as because it's unnecessary (a4cd6ba)
  • website: remove the clean script on predeploy (065a0a6)
  • website: scrolling issues (0649dcf)
  • window randomly vanishing on mac after minimise (fbfaca9)
  • windows full screen mode issues (55344a2)

This PR was generated with Release Please. See documentation.

@github-actions github-actions bot force-pushed the release-please--branches--master branch from f399030 to e0b5cda Compare April 25, 2022 01:07
@sekwah41 sekwah41 requested a review from roldanjr April 25, 2022 01:08
@sekwah41
Copy link
Member

sekwah41 commented Apr 25, 2022

I have tested this version on multiple os platforms. This should have everything minus the auto release of version files though those can be found here.

Copy link
Member

@roldanjr roldanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you much @sekwah41 for your effort in this small project. You are so amazing 🙇‍♂️

@roldanjr
Copy link
Member

I tried to install it on Mac OS and I noticed that the dock icon is the Electron logo.
image

@sekwah41
Copy link
Member

@roldanjr ill look into that after work tonight, likely an issue with updating electron and needing to rename the variable or something. The mains screens and app should work fine still though :)

@sekwah41
Copy link
Member

@roldanjr turns out the image was just referenced wrong. I think the images must have been renamed or edited because I made the change to that file name back in 2020 :P

@roldanjr
Copy link
Member

roldanjr commented Apr 28, 2022

The fullscreen break seems not working properly on Mac OS.
Can you confirm it @sekwah41 if it's working properly on other OS?

image

@sekwah41
Copy link
Member

The fullscreen break seems not working properly on Mac OS. Can you confirm it @sekwah41 if it's working properly on other OS?

image

For some reason on windows if you click on it full screens as if it's some weird delayed action then escape minimizes it. I'll take a look and see why it doesn't seem to work without interaction.

@github-actions github-actions bot force-pushed the release-please--branches--master branch from e0b5cda to 170a8cc Compare April 28, 2022 08:51
@sekwah41
Copy link
Member

I dont think this should be a blocker but if you are in minimised mode
Screenshot 2022-04-28 at 10 16 19 am

@sekwah41
Copy link
Member

Seems the issue on mac is that it doesnt respect the code fully. Windows its fine.

@github-actions github-actions bot force-pushed the release-please--branches--master branch 3 times, most recently from 0360b74 to b5a7268 Compare May 1, 2022 00:11
@13banda
Copy link

13banda commented May 15, 2022

you removed win?.setResizable(flag); in recent update
win?.setFullScreenable(true); not work in ubuntu
set resizable to full screen break.

@sekwah41
Copy link
Member

you removed win?.setResizable(flag); in recent update win?.setFullScreenable(true); not work in ubuntu set resizable to full screen break.

I've got a task on my list to look at this, this weekend. The issue is any order I can see atm seems to break it on one of the other os'. If you set it in a different order it seems to break weirdly in this version of electron so I was going to re-do it once I had all three running at once and see if I can make a uniform one which works across all the systems.

For some reason mac just doesn't properly fullscreen if the order it used to work was used but ubuntu or windows would be fine. Or alter it to work on mac and suddenly windows doesn't resize itself but has the fullscreen UI.

@github-actions github-actions bot force-pushed the release-please--branches--master branch 2 times, most recently from 86b82d1 to adb6953 Compare May 26, 2022 10:25
@sekwah41
Copy link
Member

The release is blocked by #261 as there were issues relating to resizing I disabled the logic enabling and disabling the resizing. For some reason, mac, ubuntu, and windows all seem to act differently or do not apply the setting before the next function is called altering the size.

This leaves two options.

  1. Fix the resizing logic to work on all os without being resizeable all the time
  2. Alter the CSS so users can change the size anyway to keep it always resizeable.

Copy link
Member

@sekwah41 sekwah41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comments about resizing issue

@github-actions github-actions bot force-pushed the release-please--branches--master branch from adb6953 to 7590f96 Compare July 31, 2022 11:49
@sekwah41
Copy link
Member

sekwah41 commented Jul 31, 2022

Will take a look at fixing some of these things and doing a quick release before trying the migration to Tauri.

Though a few of these issues were very fiddly as they seem to alter behaviour that bugs in different ways on different operating systems at least for the resizing issues.

Though I will look into altering the CSS to allow resizing manually to work as we would be able to take that feature across to Tauri too.

@github-actions github-actions bot force-pushed the release-please--branches--master branch from 7590f96 to 47b632e Compare August 1, 2022 20:53
@github-actions github-actions bot force-pushed the release-please--branches--master branch from 47b632e to 81296c0 Compare December 20, 2022 02:15
@sekwah41 sekwah41 merged commit 41b0b09 into master Dec 20, 2022
@sekwah41 sekwah41 deleted the release-please--branches--master branch December 20, 2022 02:23
@github-actions
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Consistent use of CSS styles
3 participants