Skip to content

Commit

Permalink
HIP: force max threads per block to be 1024 (ggml-org#11621)
Browse files Browse the repository at this point in the history
Some old/vendor forked version of llvm still use 256. Explicitly set it to 1024 to align with upstream llvm.

Signed-off-by: fxzjshm <fxzjshm@163.com>
  • Loading branch information
fxzjshm authored Feb 4, 2025
1 parent 3962fc1 commit 3ec9fd4
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions ggml/src/ggml-hip/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ endif()

message(STATUS "HIP and hipBLAS found")

# Workaround old compilers
set(CMAKE_HIP_FLAGS "${CMAKE_HIP_FLAGS} --gpu-max-threads-per-block=1024")

file(GLOB GGML_HEADERS_ROCM "../ggml-cuda/*.cuh")
list(APPEND GGML_HEADERS_ROCM "../../include/ggml-cuda.h")

Expand Down

0 comments on commit 3ec9fd4

Please sign in to comment.