[zend-date] properly calculate sunrise, sunset and twilight times #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falkenhawk
force-pushed
the
zend-date-sun-fixes
branch
from
3a45be5 to
9988ae9
Compare
When php 8.1.0 deprecated date_sunset() and date_sunrise() functions, switched to recommended date_sun_info() function is used instead (which is available in php since v5.1) but that function yields slightly different results since zenith angles are internally fixed and they are different to what zf used before. (see $horizonDeclination in Zend_Date::calcSun() - moved from Zend_Date::_checkLocation()) Yet ONLY NOW they are accurate! (calculations for civil / nautical / astronomical twilight were totally wrong before) Still values returned by date_sun_info() are slightly different in php 8.0+, (but only for sunrise/sunset, not for twilight) so yet another set of conditions have to be added to test suites.
falkenhawk
force-pushed
the
zend-date-sun-fixes
branch
from
9988ae9 to
1fcbccb
Compare
marcing
approved these changes
Nov 29, 2022
falkenhawk
commented
Nov 29, 2022
falkenhawk
added a commit
that referenced
this pull request
Dec 2, 2022
* [zend-date] fix calculating sunrise, sunset and twilight times When php 8.1.0 deprecated date_sunset() and date_sunrise() functions, switched to recommended date_sun_info() function is used instead (which is available in php since v5.1) but that function yields slightly different results since zenith angles are internally fixed and they are different to what zf used before. (see $horizonDeclination in Zend_Date::calcSun() - moved from Zend_Date::_checkLocation()) Yet ONLY NOW they are accurate! (calculations for civil / nautical / astronomical twilight were totally wrong before) Still values returned by date_sun_info() are slightly different in php 8.0+, (but only for sunrise/sunset, not for twilight) so yet another set of conditions have to be added to test suites.
falkenhawk
added a commit
that referenced
this pull request
Dec 4, 2022
* [zend-date] fix calculating sunrise, sunset and twilight times When php 8.1.0 deprecated date_sunset() and date_sunrise() functions, switched to recommended date_sun_info() function is used instead (which is available in php since v5.1) but that function yields slightly different results since zenith angles are internally fixed and they are different to what zf used before. (see $horizonDeclination in Zend_Date::calcSun() - moved from Zend_Date::_checkLocation()) Yet ONLY NOW they are accurate! (calculations for civil / nautical / astronomical twilight were totally wrong before) Still values returned by date_sun_info() are slightly different in php 8.0+, (but only for sunrise/sunset, not for twilight) so yet another set of conditions have to be added to test suites.
falkenhawk
added a commit
that referenced
this pull request
Dec 6, 2022
* [zend-date] fix calculating sunrise, sunset and twilight times When php 8.1.0 deprecated date_sunset() and date_sunrise() functions, switched to recommended date_sun_info() function is used instead (which is available in php since v5.1) but that function yields slightly different results since zenith angles are internally fixed and they are different to what zf used before. (see $horizonDeclination in Zend_Date::calcSun() - moved from Zend_Date::_checkLocation()) Yet ONLY NOW they are accurate! (calculations for civil / nautical / astronomical twilight were totally wrong before) Still values returned by date_sun_info() are slightly different in php 8.0+, (but only for sunrise/sunset, not for twilight) so yet another set of conditions have to be added to test suites.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
date_sunset()anddate_sunrise()are deprecated in php 8.1+ - switched to recommendeddate_sun_info()function (which is available since php v5.1)https://www.php.net/manual/en/function.date-sun-info.php#refsect1-function.date-sun-info-returnvalues
but that function yields slightly different results since zenith angles for sunrise/sunset/twilights are hardcoded internally
and they are different to what zf used before (see
$horizonDeclinationinZend_Date::calcSun()- moved fromZend_Date::_checkLocation())Yet ONLY NOW they are accurate! (calculations for civil / nautical / astronomical twilight were totally wrong before)