Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Enhance .testcore testcases w/ db checks (preparation) #488

Merged
merged 7 commits into from
Mar 11, 2025

Conversation

mmd-osm
Copy link
Collaborator

@mmd-osm mmd-osm commented Mar 9, 2025

PR with prep steps to address #487

  • XML parser can now be reused in other scenarios where we don't need the staticxml_backend.
  • Reusable functions in test_core are now in test_core_helper.
  • Migrate test_core to Catch2

TODO for next PR:

  • create another test_apidb_backend_* for testcore test cases
  • initialize test data, write xml contents to db

This PR also includes two left over unit tests for options and backend roles. Coverage for options.cpp was improved by adding missing test cases. Roles check now includes "importer" role.

sudo support was added for the devcontainer.

@mmd-osm mmd-osm marked this pull request as draft March 9, 2025 19:47
@mmd-osm mmd-osm changed the title [test] XML parser moved to separate file [test] Enhance .testcore testcases w/ db checks Mar 9, 2025
@mmd-osm mmd-osm linked an issue Mar 9, 2025 that may be closed by this pull request
@mmd-osm mmd-osm marked this pull request as ready for review March 10, 2025 22:29
@mmd-osm mmd-osm changed the title [test] Enhance .testcore testcases w/ db checks [test] Enhance .testcore testcases w/ db checks (preparation) Mar 10, 2025
@mmd-osm mmd-osm merged commit f07e0c4 into zerebubuth:master Mar 11, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant