Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare cli for v2 #96

Merged
merged 3 commits into from
Dec 24, 2021
Merged

Prepare cli for v2 #96

merged 3 commits into from
Dec 24, 2021

Conversation

skarahoda
Copy link

Change description

This PR actually includes 3 tasks:

  • Add support of metadata
  • Fix LinkType enum: We changed the enum from const enum to enum, so we can get all values of the enum by using Object.values(LinkType). However, this change breaks plugins. That's why I reverted the change.
  • Apply v2 changes to dev server also

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@skarahoda skarahoda self-assigned this Dec 17, 2021
yuqu
yuqu reviewed Dec 20, 2021
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@skarahoda skarahoda requested a review from yuqu December 20, 2021 15:40
@skarahoda skarahoda merged commit 9ee3a23 into main Dec 24, 2021
@skarahoda skarahoda deleted the feat/prep-v2 branch December 24, 2021 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burakaraz burakaraz burakaraz approved these changes

@aykutbulca aykutbulca aykutbulca approved these changes

@yuksely yuksely Awaiting requested review from yuksely

@okan-cakmak okan-cakmak Awaiting requested review from okan-cakmak

@yuqu yuqu Awaiting requested review from yuqu

Assignees

@skarahoda skarahoda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skarahoda @yuqu @burakaraz @aykutbulca