Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade git-url-parse #103

Merged
merged 3 commits into from
Sep 21, 2022
Merged

build: upgrade git-url-parse #103

merged 3 commits into from
Sep 21, 2022

Conversation

yuqu
Copy link
Contributor

@yuqu yuqu commented Sep 19, 2022

Change description

Upgrade vulnerable dependency git-url-parse.

1efb7f8 is implemented as a remedy for the breaking change mentioned in git-url-parse release. It seems our use cases are not affected by this breaking change. Nevertheless, I put it to cover old behavior for http/https git repo URLs (while also fixing a problem for ssh git URLs with custom ports).

Changes are going to be backported to 1.1.x versions #104

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fixes #102

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@yuqu yuqu requested a review from skarahoda September 19, 2022 20:24
@yuqu yuqu force-pushed the upgrade-git-url-parse branch from f36b7dd to dd195bb Compare September 21, 2022 14:48
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yuqu yuqu merged commit 1e04768 into main Sep 21, 2022
@yuqu yuqu deleted the upgrade-git-url-parse branch September 21, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parse-url security vulnerabilities
2 participants