This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
assertQueryContentContains searching through all nodes found #5212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -330,25 +330,23 @@ public function testAssertXpathQueryCountMax() | |||
| public function testAssertQueryContentContains() | |||
| { | |||
| $this->dispatch('/tests'); | |||
| $this->assertQueryContentContains('div#content', 'foo'); | |||
There was a problem hiding this comment.
Instead change this test case please add a new one
|
I think that there are two scenarios here.
Could you elaborate this a bit more for cover both scenarios? Thank you |
|
The documentation states that this query looks for at least one of the nodes contains the element. This is also the same functionality that was in ZF1. |
weierophinney
added a commit
that referenced
this pull request
Oct 23, 2013
assertQueryContentContains searching through all nodes found
weierophinney
added a commit
that referenced
this pull request
Oct 23, 2013
- Incorporated feedback from @Maks3w - ensured all multi-line sprint() calls had one argument per line
ghost
assigned
weierophinney
added a commit
to zendframework/zend-test
that referenced
this pull request
May 15, 2015
…aster assertQueryContentContains searching through all nodes found
weierophinney
added a commit
to zendframework/zend-test
that referenced
this pull request
May 15, 2015
- Incorporated feedback from @Maks3w - ensured all multi-line sprint() calls had one argument per line
weierophinney
added a commit
to zendframework/zend-test
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-test
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When content is not in the first node of the document, assertQueryContentContains does not find it. This change checks all the nodes for the content when using the AbstractHttpControllerTestCase.