This repository was archived by the owner on Jan 31, 2020. It is now read-only.
Allow view helpers to be simple callables #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $instanceOf = Helper\HelperInterface::class; | ||
| } else { | ||
| $instanceOf = $this->instanceOf; | ||
| } |
There was a problem hiding this comment.
We can make this simpler by removing the $instanceOf property entirely. The logic then becomes:
public function validate($instance)
{
if (is_callable($instance) || $instance instanceof Helper\HelperInterface) {
return;
}
// throw exception
}I can do that on merge.
weierophinney
added a commit
that referenced
this pull request
May 12, 2016
Allow view helpers to be simple callables
weierophinney
added a commit
that referenced
this pull request
May 12, 2016
weierophinney
added a commit
that referenced
this pull request
May 12, 2016
|
Merged to develop for release with 2.7.0. (This loosens the types allowed, making it BC.) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the user is forced to implement a
setView()andgetView()method in his view helpers, even though he's mostly likely not going to use them. This PR solves this by simply allowing any callable as a view helper. Extending classes can still specify a specific interface or class to check for, but the primary helper plugin manager now accepts any callable. This should be no BC break, but @weierophinney probably knows best.