This repository was archived by the owner on Jan 31, 2020. It is now read-only.
Delete Single or Multiple Containers in Placeholder View Helper #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froschdesign
previously requested changes
Nov 12, 2018
| @@ -63,7 +63,7 @@ $this->placeholder('foo') | |||
| <?= $this->placeholder('foo') ?> | |||
| ``` | |||
|
|
|||
| The above results in an unodered list with pretty indentation. | |||
| The above results in an unordered list with pretty indentation. | |||
doc/book/helpers/placeholder.md
Outdated
|
|
||
| ```php | ||
| <?php | ||
| // Delete a single Container |
There was a problem hiding this comment.
Please split this code example. One example for deleting a container and a second example to clear all containers.
### Delete a single container
```php
$this->plugin('placeholder')->deleteContainer('myNamedContainer');
```### Clear all containers
```php
$this->plugin('placeholder')->clearContainers();
```
|
@gsteel |
weierophinney
dismissed
froschdesign’s stale review
Feedback was incorporated by author.
…eholder containers
In these particular cases, you really do not want to operate on the return value, as it's ambiguous what that would mean.
|
Thanks, @gsteel! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to delete single containers or remove all containers from the placeholder view helper. This is useful when you're running with Swoole for example - All (I Think) other placeholder implementations offer a
deleteContainer()method.