This repository was archived by the owner on Jan 31, 2020. It is now read-only.
Updated to service manager 3 #3
Merged
+84
−94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param mixed $plugin | ||
| * @return void | ||
| * @throws Exception\InvalidArgumentException if invalid | ||
| * {@inheritdoc} | ||
| */ | ||
| public function validatePlugin($plugin) |
There was a problem hiding this comment.
Remove this method, and instead define an $instanceOf property with the value Decorator\DecoratorInterface::class.
| 'tag' => 'Zend\Tag\Cloud\Decorator\HtmlTag', | ||
| protected $aliases = [ | ||
| 'htmlcloud' => Decorator\HtmlCloud::class, | ||
| 'htmltag' => Decorator\HtmlTag::class, |
There was a problem hiding this comment.
The above two should also have the aliases htmlCloud and 'htmlTag`, as those were used previously. I can do that on merge, though.
weierophinney
added a commit
that referenced
this pull request
Dec 15, 2015
Updated to service manager 3
weierophinney
added a commit
that referenced
this pull request
Dec 15, 2015
weierophinney
added a commit
that referenced
this pull request
Dec 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.