This repository was archived by the owner on Jan 30, 2020. It is now read-only.
Provide forwards compatibility with servicemanager v3 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed zend-di. It's only be using for a single exception class *in a test*, and can be replaced with an SPL exception. - Updated zend-servicemanager to `^2.7.5 || ^3.0` - Updated PHP to `^5.5 || ^7.0` - Changed dev-develop branch alias to `2.6-dev`
- As it is used in a mock, and doesn't model what would actually be thrown anyways.
Implements a new test, AssertionManagerCompatibilityTest, which ensures that code works correctly for both v2 and v3. Additionally, updates the AssertionManager to follow the current migration guidelines.
This adds builds to the Travis matrix to allow testing both on servicemanager v2 and v3.
weierophinney
added a commit
that referenced
this pull request
Feb 3, 2016
weierophinney
added a commit
that referenced
this pull request
Feb 3, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the develop branch to make it forwards compatible with zend-servicemanager v3 (vs only compatible), allowing a 2.6.0 version that supports both v2 and v3.
The following changes were made:
^2.7.5 || ^3.0.AssertionManagerCompatibilityTest, which leverages zend-servicemanager'sCommonPluginManagerTraitto test both v2 and v3 compatibility of theAssertionManagerimplementation.AssertionManagerto work under both v2 and v3:$sharedByDefault+$shareByDefaultvalidate()andvalidatePlugin()methods