This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Allow arrays as constant values in generated constants #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@basz can you add a test case for it? |
|
@Ocramius update by author |
Ocramius
suggested changes
Sep 30, 2016
| $propertyGenerator = new PropertyGenerator('FOO', $generator); | ||
| $propertyGenerator->setConst(true); | ||
|
|
||
| $this->assertInternalType('string', $propertyGenerator->generate()); |
There was a problem hiding this comment.
Your data provider should probably also give the expected string outcome.
| [new PropertyValueGenerator('bar', PropertyValueGenerator::TYPE_STRING)], | ||
| [new PropertyValueGenerator(null, PropertyValueGenerator::TYPE_NULL)], | ||
| [new PropertyValueGenerator(null, PropertyValueGenerator::TYPE_NULL)], | ||
| [new PropertyValueGenerator('PHP_EOL', PropertyValueGenerator::TYPE_CONSTANT)], |
There was a problem hiding this comment.
What about nested values? Such as ['foo' => ['bar' => 'baz']]?
There was a problem hiding this comment.
What about them? They aren't asserted by the generator afaik...
Ocramius
changed the title
Ocramius
added a commit
that referenced
this pull request
Oct 24, 2016
Ocramius
added a commit
that referenced
this pull request
Oct 24, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a valid const, but can't be generated