This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Resolve issues with traits in ClassScanner #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only the first use statement would be accounted for when getting lists of traits, due to unnecessary break statements at the end of the loop. Fixes #58 - If one of the methods touched by this commit, such as getTraitNames(), or getTraits(), which calls getTraitNames(), was called as the first action on this class, no traits would be returned, due to the fact that scan() was not called at the start of the method. Fixes #57
|
I'd really appreciate it if this and #61 could be reviewed. I'm writing a piece of software that depends on these issues being resolved |
|
Is there a reason why this wasn't looked at before the release of v3.0.3? |
|
@djmattyg007 Honestly, I accidentally skipped over it when reviewing PRs yesterday. It looks like we'll be doing a 3.0.4 quite soon, though, so I'll merge this now and target that version. |
weierophinney
added a commit
that referenced
this pull request
Jun 28, 2016
Resolve issues with traits in ClassScanner
weierophinney
added a commit
that referenced
this pull request
Jun 28, 2016
basz
added a commit
to basz/zend-code
that referenced
this pull request
Sep 28, 2016
* 'master' of https://github.com/zendframework/zend-code: (39 commits) Fix Travis code convention Fix Travis code convention Fix Travis code convention Fix Travis code convention 1. Fix ClassScanner::getInterfaces() which don't work with Interface. 2. add TestCase ClassScannerTest::testGetInterfacesFromInterface(). Remove fast_finish flag Bumped to next dev version (3.0.5) Added CHANGELOG for zendframework#75 Separated new tests to separate methods testCorrectExtendNamesFromGlobalNamespace add tests Added CHANGELOG for zendframework#59 Update ClassGenerator.php fast fix Bumped to next dev version (3.0.4) Set date for 3.0.3 Added CHANGELOG for zendframework#72 Added CHANGELOG for zendframework#69 Added CHANGELOG for zendframework#61 Provide a fix for issue zendframework#70 ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of traits, due to unnecessary break statements at the end of the loop.
Fixes Zend\Code\Scanner\ClassScanner only properly records the first use statement inside a class #58
or getTraits(), which calls getTraitNames(), was called as the first
action on this class, no traits would be returned, due to the fact
that scan() was not called at the start of the method. Fixes Zend\Code\Scanner\ClassScanner::getTraitNames() does not call scan() before running #57