Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Code refactor with new zend-eventmanager #20

Merged
merged 2 commits into from
Nov 11, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@
},
"require": {
"php": ">=5.5",
"zendframework/zend-eventmanager": "~2.5"
"zendframework/zend-eventmanager": "dev-develop as 2.7.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can actually set this to ^2.6|^3.0, as the changes made in here are compatible with 2.6!

I'll take care of that on merge. That also means we can target this for an immediate 2.6 release, pending any other pull requests.

},
"require-dev": {
"doctrine/common": ">=2.1",
"zendframework/zend-stdlib": "~2.5",
"zendframework/zend-stdlib": "~2.7",
"zendframework/zend-version": "~2.5",
"fabpot/php-cs-fixer": "1.7.*",
"phpunit/PHPUnit": "~4.0"
Expand Down
4 changes: 2 additions & 2 deletions src/Annotation/AnnotationManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@ public function createAnnotation(array $annotationData)
]);

$eventManager = $this->getEventManager();
$results = $eventManager->trigger($event, function ($r) {
$results = $eventManager->triggerEventUntil(function ($r) {
return (is_object($r));
});
}, $event);

$annotation = $results->last();

Expand Down
1 change: 0 additions & 1 deletion test/Annotation/AnnotationManagerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ public function testAllowsMultipleParsingStrategies()
{
$genericParser = new Annotation\Parser\GenericAnnotationParser();
$genericParser->registerAnnotation(__NAMESPACE__ . '\TestAsset\Foo');

$doctrineParser = new Annotation\Parser\DoctrineAnnotationParser();
$doctrineParser->registerAnnotation(__NAMESPACE__ . '\TestAsset\DoctrineAnnotation');

Expand Down