This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Fixed class generator ignoring use aliases for extended class #144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a fix for the class generator when using a use alias for the extended
class.
Bug explanation
Before this patch, the class generator would ignore all use aliases. This resulted
in an incorrect extends class. For example:
would result in:
When using an FQCN for the extended class, it would ignore the use statement:
would result in:
Fix explanation
This PR fixes the ClassGenerator by checking whether the extended class matches
one of the use statements.
It supports the following varieties:
Using an alias as the extended class
will result in:
Using an alias of the extended class namespace
will result in:
Using an FQCN as the extended class
The class generator will replace the extended class with its alias, if an exact use
statement match is defined.
will result in:
The class generator will replace the namespace of the extended class with its alias,
if an exact use statement match is defined.
will result in: