This repository was archived by the owner on Jan 29, 2020. It is now read-only.
Generate Interfaces #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -142,6 +144,9 @@ public static function fromArray(array $array) | |||
| break; | |||
| case 'final': | |||
| $method->setFinal($value); | |||
| case 'interface': | |||
There was a problem hiding this comment.
Please add a test for cover this.
There was a problem hiding this comment.
There was a problem hiding this comment.
It can't be done because clearly there is a bug here. missing break statement and later duplicate.
Please don't rebase until the PR review ends or maintainer request it.
There was a problem hiding this comment.
It is fixed now.
BTW, It would affect final not interface
FabioBatSilva
force-pushed
the
interface-generator
branch
from
67abe91 to
ac387b6
Compare
|
ping @Maks3w |
|
@FabioBatSilva EXCELLENT pull request — great tests, clean code. Thanks! |
weierophinney
added a commit
that referenced
this pull request
Nov 18, 2015
|
Merged to develop for release with 2.6.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.