Skip to content
This repository was archived by the owner on Nov 23, 2024. It is now read-only.

Replace Material Paper with Garden Well #557

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

kerrisim
Copy link
Contributor

@kerrisim kerrisim commented Mar 2, 2021

Short description

Description

Using Garden's Well component to replace Material UI's Paper component within the Admin dashboard page

References

Github Issue

Screenshots (if needed)

Before
After Screen Shot 2021-03-17 at 16 17 13 Screen Shot 2021-03-17 at 16 05 04

Risks (if any)

  • [Low] - UI component change

@kerrisim kerrisim requested a review from a team March 2, 2021 04:13
Copy link
Contributor

@samzx samzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Could we add margins (right, left) between the two horizontal wells (for all of them)? Using styled components if possible.

I think it'd look better that way, especially since the Wells have a border radius and it being so close each other they kind of look like they're over lapping a bit too.

Edit: ie [ ][ ] becomes [ ] [ ]

@kerrisim
Copy link
Contributor Author

Hey @samzx, I added some margins to the Well components. I also updated the screenshots to what they look like now. Does that work?

@kerrisim kerrisim force-pushed the ksim/replace-material-paper branch from 13b1a9c to 7818c21 Compare March 24, 2021 03:46
Copy link
Contributor

@samzx samzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks for that! 😊

Copy link
Contributor

@samzx samzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only other thing to add is maybe creating a StyledWell component instead of the const styles

ie.

const StyledWell = styled(Well)`
    width: 100%;
    height: 100%;
    padding: 20px;
`

and using that instead of the Well component. Lmk if you'd like to pair on that :)

@kerrisim
Copy link
Contributor Author

I didn't know that styled components was a thing. That's pretty cool!! I've made the change ☺️

@kerrisim kerrisim merged commit 7287392 into master Mar 24, 2021
@kerrisim kerrisim deleted the ksim/replace-material-paper branch March 24, 2021 05:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants