Fix various issues in TUs marked Equivalent
#2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the process of adding a feature that lets objdiff show diffs for relocations inside data, which are currently not shown anywhere so they can be almost impossible to notice. While testing it I noticed several
EquivalentTUs in TP that aren't actually equivalent due to wrong relocations, such as switch statement jump tables being out of order, wrong PTMFs in arrays, vtable entries being out of order, andcDmr_SkipInfobeing at the wrong address(?). So this PR should make them all actually be equivalent.(While I was fixing these I decided to try switching some of these equivalent TUs to be matching instead by fixing regalloc issues and other minor oddities, but most still can't be linked due to the weak function ordering problem.)
Note that I didn't look through
NonMatchingTUs for wrong relocations, but there probably are some more there.