d_a_obj_waterPillar + d_a_obj_syRock Equivalent (weak ordering) #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marwernerh
commented
Jan 3, 2025
marwernerh
commented
- Added fake struct padding (comes before dEvLib_callback_c inheritance)
- Basic documentation
- Added fake Chk inlines to dBgS_Acch
- Added AT_TYPE_100 to cCcD_ObjAtType
* Added fake struct padding * Added fake Chk inlines to dBgS_Acch * Added AT_TYPE_100 to cCcD_ObjAtType
* Deleted fake Chk inlines from dBgS_Acch * Removed duplicated, but commented, static check for struct size * Renamed two d_a_obj_waterPillar fields according to comments
TakaRikka
approved these changes
Jan 3, 2025
include/d/actor/d_a_obj_syRock.h
Outdated
Comment on lines
78
to
95
| inline BOOL getArg0() { | ||
| return shape_angle.x & 0xF; | ||
| } | ||
|
|
||
| // Switch to determine whether or not the stalactite has been broken | ||
| inline u32 getSwBit1() { | ||
| return fopAcM_GetParamBit(this, 0, 8); | ||
| } | ||
|
|
||
| // Switch to determine whether or not the stalactite should be broken automatically when player is in range | ||
| inline u32 getSwBit2() { | ||
| return fopAcM_GetParamBit(this, 8, 8); | ||
| } | ||
|
|
||
| // Event ID for Midna to stop and note the stalactite that fell by itself | ||
| inline s32 getEvetID() { | ||
| return fopAcM_GetParamBit(this, 16, 8); | ||
| } |
There was a problem hiding this comment.
not a major thing but just for future reference, functions you define in the class like this don't need the inline keyword. they will automatically be inlined
src/d/actor/d_a_obj_syRock.cpp
Outdated
| // NONMATCHING | ||
| // Set base transform matrix of current model and the background matrix both to the contents of now | ||
| mpModels[mIsUnbroken]->setBaseTRMtx(mDoMtx_stack_c::get()); | ||
| PSMTXCopy(mDoMtx_stack_c::get(), mBgMtx); |
There was a problem hiding this comment.
another minor thing, you can leave off the PS prefix and just use MTXCopy for example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.